Commit Graph

22 Commits

Author SHA1 Message Date
Xingyi Zhou cefeb33baf
Merge pull request #17 from cclauss/patch-1
Add comments to explain why nms = None
2019-04-22 20:37:03 -05:00
cclauss 1316d370fe
Add comments to explain why nms = None
Explicit is better than implicit.
2019-04-21 08:10:15 +02:00
Xingyi Zhou c4792e3955
Merge pull request #16 from xingyizhou/revert-13-patch-1
Revert "from model.nms_wrapper import nms for lines 132 and 168"
2019-04-20 22:07:23 -07:00
Xingyi Zhou 88fafa1b0f
Revert "from model.nms_wrapper import nms for lines 132 and 168" 2019-04-20 22:05:48 -07:00
Dequan Wang 8611fbb954
Merge pull request #13 from cclauss/patch-1
from model.nms_wrapper import nms for lines 132 and 168
2019-04-20 16:00:03 -07:00
cclauss 922228813b
from model.nms_wrapper import nms for lines 132 and 168
[flake8](http://flake8.pycqa.org) testing of https://github.com/xingyizhou/CenterNet on Python 3.7.1

$ __flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics__
```
./src/lib/models/networks/dlav0.py:417:5: F821 undefined name 'dla'
    dla.BatchNorm = bn
    ^
./src/tools/voc_eval_lib/model/test.py:132:14: F821 undefined name 'nms'
      keep = nms(dets, thresh)
             ^
./src/tools/voc_eval_lib/model/test.py:168:14: F821 undefined name 'nms'
      keep = nms(cls_dets, cfg.TEST.NMS)
             ^
3     F821 undefined name 'dla'
3
```
__E901,E999,F821,F822,F823__ are the "_showstopper_" [flake8](http://flake8.pycqa.org) issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.
* F821: undefined name `name`
* F822: undefined name `name` in `__all__`
* F823: local variable name referenced before assignment
* E901: SyntaxError or IndentationError
* E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
2019-04-20 08:32:41 +02:00
Dequan Wang 5919b13176
Merge pull request #11 from cclauss/patch-1
Add automated testing on Python 3.6 and 3.7 on Travis CI
2019-04-19 16:42:28 -07:00
cclauss 1ce96c48a8
Add automated testing on Python 3.6 and 3.7 on Travis CI
The owner of the this repo would need to go to https://travis-ci.com/profile, log in with GitHub credentials, select the __free plan__, and flip the repository switch on to enable free automated testing of all pull requests.  Travis will lint with flake8 and then run __python runtests__.
2019-04-19 08:19:06 +02:00
Xingyi Zhou 720779af97
Merge pull request #10 from dannykuo25/patch-1
Update README.md
2019-04-19 00:52:16 -05:00
Danny Chien-Kuo Kuo 6599f8df4f
Update README.md
tackle word misspelling issue
2019-04-19 11:18:49 +08:00
Xingyi Zhou d19b524315 fix legacy typos in code 2019-04-18 17:42:04 -05:00
Xingyi Zhou 7f411457b4 Merge branch 'master' of github.com:xingyizhou/CenterNet 2019-04-18 17:35:19 -05:00
Xingyi Zhou 7ac3e96a79
Merge pull request #6 from cclauss/patch-1
Undefined name: opt.K --> self.opt.K
2019-04-18 17:36:11 -05:00
Xingyi Zhou 61f7c5c884 modify readme 2019-04-18 17:35:17 -05:00
cclauss d0067e886d
Undefined name: opt.K --> self.opt.K 2019-04-18 10:13:10 +02:00
Xingyi Zhou d133939e9e fix typo in experiments 2019-04-17 17:04:36 -05:00
XingyiZhou be7019023b add experiments and fix typo 2019-04-17 09:53:59 -05:00
Xingyi Zhou d74e0e9392 add arXiv 2019-04-16 19:44:58 -05:00
Xingyi Zhou 819e0d0dde change readme 2019-04-16 17:25:27 -05:00
Xingyi Zhou 4a6c42ff53 fix typo 2019-04-16 13:44:32 -05:00
Xingyi Zhou f16ef636dd init 2019-04-16 13:36:21 -05:00
Xingyi Zhou b576e6f238
Initial commit 2019-04-16 13:39:14 -05:00