Case when w_ptr and r_ptr of dma buffer are equal, means
that buffer is empty. During adding traces to buffer, we
should't lead to that equality.
Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
we now using git tag for version number control, but if
we release the code without .git/ folder, the git tag version
number is not present, so will cause compile error.
add the .tarball-version file as the local version number file,
it still can be generated by the autogen.sh from git tag. So
everytime anyone make a git tag should still modify the
.tarball-version file.
Signed-off-by: Zhu Yingjiang <yingjiang.zhu@linux.intel.com>
In functions pipeline_buffer_connect and pipeline_comp_connect
I have removed possibility to make log with pipe/comp ids, because
pipeline ptr in struct comp_dev is not initialize until
connect_upstream or connect_downstream invocation.
fixes#562
Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
Unified access macros across ApolloLake, CannonLake, SueCreek, Icelake.
Including clean up in HP SRAM init procedure at boot loader.
Signed-off-by: Lech Betlej <lech.betlej@linux.intel.com>
On receiving an IPC IRQ the handler currently does not check the
IRQ mask. This means notification received ACKs (i.e. for trace updates)
from the host may be reported as duplicate host command IPCs.
Fix this by checking IPC IRQ mask.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
On D3 entry FW needs to power gate both LP & HP SRAM banks. The power
gating is done from code executed from L1 cache.
Signed-off-by: Lech Betlej <lech.betlej@linux.intel.com>
When host stop fails, it should return the errno.
This patch fixes the coverity the below coverity check issue:
static int host_trigger(struct comp_dev *dev, int cmd)
273{
274 struct host_data *hd = comp_get_drvdata(dev);
275 int ret = 0;
276
277 trace_host("trg");
278
279 ret = comp_set_state(dev, cmd);
280 if (ret < 0)
281 goto out;
282
283 switch (cmd) {
284 case COMP_TRIGGER_STOP:
CID 324978 (#1 of 1): Unused value (UNUSED_VALUE)
returned_value: Assigning value from host_stop(dev) to ret here,
but that stored value is overwritten before it can be used.
285 ret = host_stop(dev);
286 /* fall through /
287 case COMP_TRIGGER_XRUN:
288/ TODO: add attribute to dma interface and do run-time if() here */
289#if defined CONFIG_DMA_GW
value_overwrite: Overwriting previous write to ret with value from
dma_stop(hd->dma, hd->chan).
290 ret = dma_stop(hd->dma, hd->chan);
291#endif
Signed-off-by: Libin Yang <libin.yang@intel.com>
Buffer overflow was possible when mbox traces of varying length were
logged consecutively, near end of the buffer, petentially leading to
next segment of memory being overwritten with garbage.
Also log entry was pasted twice, once to the on-stack buffer, and then
separately to the mailbox. Now data is being copied to both from the same
source.
Also separating this to a function call, reduces overall .text section of FW.
Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
Split the larger ABI files into smaller more manageable chunks. Also
split by end user into IPC and user space ABIs.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Liam Girdwood