This patch adds a library for window functions. The window functions
are used to mitigate artefacts (from nature of FFT) to spectra when
computing FFT for a finite long chunk of audio. The currently provided
window functions are Blackman, Hamming, Povey, and rectangular.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This is another tplg_parser and testbench update on the road to provide
further flexibility around supporting new modules and IPC versions.
There will more to follow.
Changes are mostly mechanical code movements i.e. moving testbench related code
to the testbench, splitting the files into per module/component files and
making some functions static and public.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
On host based builds we sometimes see that panic.h redefines assert().
Fix this. This will go away in the future as Zephyr will fully take care
of assert() on host.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
An IPC4 widget may support multiple I/O queue. Queue ID is
required during widget binding in route setup.
This patch adds sink_pin_binging and src_pin_binding classes
for multiple I/O queue support.
For widget requires special pin(queue) binding, sink_pin_binding
or src_pin_binding should be defined in the widget object. So
that the kernel knows which pin to use during widget binding
by parsing topology.
Note that pin binding should be defined for all sink/source pins
or for none. Even if there is only one sink pin requires special
pin binding, pin binding should be defined for all sink pins, and
for pins that are not used, give the value "NotConnected". This rule
applies to source pins, too.
Example: smart_amp widget has two sink pins and one source pin,
and its feedback sink pin requires special pin binding, so we have to
define sink_pin_binding objects within smart_amp object like this:
Object.Base.sink_pin_binding.1 {
# the main sink pin is connected to host for playback data
sink_pin_binding_wname "copier.host.1.1"
}
Object.Base.src_pin_binding.2 {
# the feedback sink pin is connected to capture dai for codec feedback.
sink_pin_binding_wname "copier.SSP.2.1"
}
In this example, smart_amp is connected to host and DAI directly,
it is also possible to be connected to host and DAI indirectly (with
gain or other widget in the middle).
Signed-off-by: Chao Song <chao.song@linux.intel.com>
These two tokens will be used by the kernel to decide the
supported number of sink/source pins, thus to allocate
correct widget queue id in route setup.
These two tokens are mandatory for IPC4 widgets, because
the default value in Linux kernel is zero, which is invalid
for queue id allocation.
Signed-off-by: Chao Song <chao.song@linux.intel.com>
Restores ability to compile on Windows with MSYS.
Fixes commit dcf0577a77 ("logger: allow starting before the driver is
loaded")
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Usually when processing COMP_TRIGGER_PAUSE or COMP_TRIGGER_STOP if a
component returns PPL_STATUS_PATH_STOP it means, that the trigger
propagation should stop and the pipeline should be kept alive.
However, in some cases propagation should be stopped, but the
pipeline should be terminated. This is the case with the selector
component, when used in a keyword detection pipeline. Add a new
PPL_STATUS_PATH_TERMINATE return value for such cases.
BugLink: https://github.com/thesofproject/sof/issues/5398
Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Moved hardcoded cycles values for DMIC IO from dmic.h header
to per-platform configuration file (defconfig files for
non-Zephyr builds and app/boards for Zephyr builds).
Added new entry to intel drivers Kconfig - CONFIG_DMIC_HW_IOCLK.
Modification of this clock value may be used for testing purposes
like building firmware for FPGA or simulator.
Signed-off-by: Andrey Borisovich <andrey.borisovich@intel.com>
It was a typo while adding libutil.a to CMakeLists.txt.
This commit unifies the naming with other platforms.
Signed-off-by: Ming Jen Tai <mingjen_tai@realtek.com>
This reverts commit a0b832686c.
There was a PR merge "conflict" as the log defines we're in different
place in the file. This same log define was already added in commit:
2c4e403d4d
So remove the duplicate.
Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
This patch adds tests for 16-bit FFT library version. The test SNR
is improved by using sine frequency that matches with length of FFT.
It allows to get highest SNR in transform without need for window
functions in test and attenuation in the signal.
The 32 bit FFT tests are updated to use the same signal generator.
With this criteria the minimum SNRs for 32 bit to pass could be
increased to 95 - 132 dB.
Also tests were added for 512 size FFT in addition to 256 and 1024.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch adds lower RAM and lower MCPS consuming FFT
for 16 bit data. The twiddle factors save from .bss
4096 bytes. For e.g. 512 bin FFT the saving for runtime is
additional 4096 bytes.
The previous fft.c has been split to fft_common.c and fft_32.c for
32 bits version. The new 16 bit version is in fft_16.c. The name
of previous fft_execute() is changed to fft_execute_32(). Common
function fft_plan_new() takes FFT word length 16 or 32 as new
last argument.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch adds script tools/tune/fft/export_twiddle.m. Since
the data in original twiddle.h differs by one LSB in few
items the file is replaced with one generated with the script.
The identifier 32 is added to header name and variables names
as preparation to add 16 bit FFT version.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
In mixout_prepare() mixin->pipeline can be NULL, check it before
dereferencing.
BugLink: https://github.com/thesofproject/sof/issues/6118
Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Remove mt8186 unused topologies.
We use sof-mt8186 on our demo board, sof-mt8186-mt6366-rt1019-rt5682s
and sof-mt8186-mt6366-da7219-max98357 will no be used anymore.
Signed-off-by: Chunxu Li <chunxu.li@mediatek.com>
Remove duplicate configs with base IPC4 overlay and add PM related
configs to be able to compile upstream Zephyr SSP changes.
Also enable ALH native driver.
Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
Upstream zephyr has removed "Label" from xtensa device tree definitions
thus device_get_binding stopped to work for sof. So change the code to
use device tree macros.
Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
IPC4 SOF_IPC4_MOD_INIT_INSTANCE provides size of the configuration
blob for the module. This size should be passed down to module adapter
and forwarded to module.
There are several reasons for using it:
- consistency with IPC3 flow;
- need for passing the size to IADK loadable modules;
- possibility to graceful failure in case of configuration inconsistency.
Signed-off-by: Jaroslaw Stelter <Jaroslaw.Stelter@intel.com>
Ubuntu 22.04 has ALSA 1.2.6 without ASRC failure #2543
Building in the container is much slower and updating the container is
also very time-consuming. Must be used only when really required.
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Ideally PLATFORM_DCACHE_ALIGN should be equal with DCACHE_LINE_SIZE,
but on i.MX dcache line size is 128 and it is too big for XTOS based
memory allocator.
See commit 8354454b4d ("platform: imx: Fix PLATFORM_DCACHE_ALIGN")
On the other hand the current value which is 4 doesn't work well with
Zephyr.
So, increase the PLATFORM_DCACHE_ALIGN to 32 which works well for XTOS /
Zephyr.
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
Although this patch doesn't support large_config_set|get and
corresponding per-channel process, it can support simple usage
of selector and support capture applications like voice recoder,
zoom on windows platform. It will be used for WOV development
in recently.
Signed-off-by: Rander Wang <rander.wang@intel.com>
The aim of this patch is to fix the following issue:
after some pause-release operations the sound would play
with higher volume in one earpiece compared to the other one.
This seemed to happen only during a certain part of some song
(the beginning).
By removing the unnecessary set of CSR_START register in
edma_start the problem seemed to have disappeared. Setting
aforementioned register in edma_start is not necessary
because we don't need to explicitly start a channel in the
software. The hardware will take care of it.
Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Since we introduced a new function used to handle the release
case (sai_release), we want to handle COMP_TRIGGER_RELEASE
using said function and not use sai_start.
The aim of this and the previous patch is to fix the
following issue: after a sequence of pause-release operations a
static sound would play along with the song. This static sound
would sometimes disappear after another sequence of pause-release
operations and would appear again after another sequence of
those operations.
Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Since the release and start operations should behave
differently, we need to add a new function which will
be used to handle the release case.
Initially, release would be treated just as start which is not
really correct because:
1) we don't need to do a software reset of the SAI.
(according to the documentation, apart from
resetting the SAI internal logic, it was also
resetting the FIFO read and write pointers which
was not required)
2) we don't need to enable the flags that were
not disabled by sai_stop.
Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Currently, SDMA's edma_start considers that COMP_STATE_SUSPEND
is a state from which you can get to COMP_STATE_ACTIVE which
is not true because the SDMA channel never reaches that state.
According to the device state diagram, we can only reach
the COMP_STATE_ACTIVE state if we are currently in
COMP_STATE_PAUSED or COMP_STATE_PREPARE.
Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
On COMP_TRIGGER_RELEASE, dai_trigger first calls edma_release and then
calls edma_start. Currently, edma_release changes the state of the
channel to COMP_STATE_ACTIVE which is wrong because that state
should be achieved after calling edma_start.
Since we know that edma_release is followed by edma_start the
correct state for the channel after a edma_release should
be COMP_STATE_PREPARE.
Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Currently, EDMA's edma_start considers that COMP_STATE_SUSPEND
is a state from which you can get to COMP_STATE_ACTIVE which
is not true because the EDMA channel never reaches that state.
According to the device state diagram, we can only reach
the COMP_STATE_ACTIVE state if we are currently in
COMP_STATE_PAUSED or COMP_STATE_PREPARE.
Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
Add hifi3 & hifi4 version implementation of mixer processing functions.
The hifi version functions can save at least 47% cycles than C version.
Signed-off-by: Andrula Song <xiaoyuan.song@intel.com>
Parameters audio_fmt.depth and audio_fmt.valid_bit_depth are
expressed in bits. Therefore should be divided by 8 when set for params:
params->sample_container_bytes
params->sample_valid_bytes
Signed-off-by: Jaroslaw Stelter <Jaroslaw.Stelter@intel.com>
This causes problems when displaying heap traces.
Fixes: b67c2bf0d9 ("alloc: Making heap trace dump more readable")
Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
At present module_adapter, period_bytes is calculated assuming the schedule
period is 1ms, which could be arbitrary in practice determined by the
topology.
This commit replaces the calculation code by audio_stream_period_bytes().
In addition, the timing for getting period_bytes is moved to the beginning
of prepare() (prior to the module prepare). At that moment it is guaranteed
that all parameters in components/buffers are settled through the pipeline.
Signed-off-by: Pin-chih Lin <johnylin@google.com>
Add log definition for Zephyr allowing to build this module
for Zephyr when logging is enabled.
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Fixes pylint warning `scripts/xtensa-build-zephyr.py:426:5: W0621:
Redefining name 'platform' from outer scope (line 14)
(redefined-outer-name)` and reduce "grep confusion": the script uses
`platform` A LOT.
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
There's just too many of them and fixing them would cause a lot of churn
at a wrong time (big migration to west happening now)
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
shlex.join() requires 3.8, maybe others too. 3.8 is 3 years old and it's
the default Python version in Ubuntu 20.04
Fixes#6121
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Seppo Ingalsuo