This patch provides needed maintenance. The pipelines
missed the volume ramp tokens and caused topology build fail for
topologies those would use the pipeline macros
pipe-eq-fir-volume-playback.m4 and pipe-eq-iir-volume-playback.m4.
The embedded filter coefficients in these pipelines were replaced
by included default FIR and IIR filter coefficients to fix ABI
incompatibility in the configuration blobs and ease future
maintenance of these pipelines.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
driver
The BE id for amplifier pipeline should be changed to 6 to align with
machine driver (The commit ASoC: Intel: sof-rt5682: correct naming for
dmic16k).
Cc: Sathya Prakash M R <sathya.prakash.m.r@intel.com>
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Add volume component, change to use 16KHz sample rate, and modify the
PCM ID from 5 to 8, as it is in lower priority comparing with pipelines
like amplifier.
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Extracts DSP core defines to the separate platform headers.
It was partially done before for cAVS platforms.
It's a step forward towards full header cleanup.
Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
This patch adds check for sample to not exceed S24_LE range that
could happen in int32_t type storage. The existing check for
abs(delta) > 1 does not cover such case if e.g. the reference
volume code would output e.g. INT24_MAX and the FW component
INT24_MAX + 1.
Similar check is added for every reference volume function that
outputs S24_LE format.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Some codecs require BCLK to be on for some time,
before sending any data. It can be achieved with delay between
enabling BCLK and DMA that should be given in topology.
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Xrun recover failure will flush all over the memory window that we can't
get the log of the first error, let's disable it before the flag is
moved to kconfig and fw_ready IPC, to rescue logs and debugging.
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
We should not get 0 size from dw_dma_avail_data_size() and
dw_dma_avail_data_size(), if that happened, something might be wrong,
e.g. the dma channel is not enabled, here logging out the channel
enabling status for debugging.
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
We should use the absolute value for the activation comparing, and no
need to take extra handling to those samples with low enough level.
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Move ctl_elem pointers and buffer initialization out of main(), and
replace calling alloca APIs with malloc ones to make they are shareable
between different functions.
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Firmware may use different component specified type in abi header, to
support more than one kcontrols for the same component, here add '-t' to
support specifying this component specified type in the abi header.
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Split buffer allocating and freeing part from main(), add separated
functions and call them from main().
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Using '-r' with '-s' means no abi header for the input file, and asks
for not dumping abi header when using '-r' without '-s'.
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
This will be used on large input file scenario, we need to allocate
buffer according to the input file size.
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
We might dump kcontrol values in different format, create data_dump()
and csv_data_dump() for that.
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Add a globle struct which will store params and be shared among
functions in the later commits, to make the code more readable.
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
As dmic only support 16 bit or 32 bit, we configure dmic dai to be
s32_le, and pipelines to be s24_le.
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
We need volume component after dmic for either volume change or format
converting, here add volume component between dmic and kpb.
And after this, our kwd can support all s16_le, s24_4le, and s32_le PCM
capabilities.
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Depending on the topology, buffer size might not be multiple of dma
transfer size. So, round host buffer size up to nearest dma transfer
size multiple and possibly resize the host buffer.
Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
Add resize function to buffer_set_size. This is useful, because we might
have situations where external parameter like stream sample rate or dma
transfer size is not compatible with buffer size from topology. So this
allows to change the buffer bigger and also to free memory if less space
is needed.
Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
M/N divider is needed for getting BCLK rates,
that are not dividers of MCLK.
In such a case, FW will try to find set of M, N and SCR values
needed to achieve target BCLK.
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Mux component was lacking reset function implementation. This is to
address this issue.
Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
We need initial a default buffer for model data at component new()
stage, and make sure we have non-0 size of this buffer otherwise, the
get_data cmd will fail.
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Improves traces for comp_update_buffer_produce
and comp_update_buffer_consume functions. Now
we will be able to easy identify failing components.
Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Changes behavior for DMA_COPY_PRELOAD flag.
DW-DMA should just start transfer the same way
as for DMA_COPY_ONE_SHOT. It fixes playback
for platforms using DW-DMA for host transfers.
Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Changes DW-DMA release handling for configurations
not using hardware linked list support. We should
not make any additional copies in such case.
Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Add struct model_data to manage model related stuff.
For set_model, re-allocate buffer at the 1st IPC, calculate crc after the
last IPC is handled.
For get_model, output the crc value at the 1st IPC.
Todo: add crc32 value to the struct sof_ipc_ctrl_data may be the next
step, it will require ABI change.
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
We are aligned to use separate IPC for set_config and set_model, so
don't allocate model buffer at set_config stage, but do that in the
first IPC for model blob config IPC sequences.
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Changes pipeline's preload conditions to take into
consideration the situation, where we don't always
want to do playback preload, because the sink part
of pipeline is already running e.g. mixer topology.
However the host component still needs to perform
preload on its own, so for now we make the decision
based on stream's direction.
Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Sets host copy mode to one shot for platforms
with CONFIG_HOST_PTABLE set. Note: this setting
shouldn't be dependent on CONFIG_HOST_PTABLE,
but rather should be set in platform specific code.
Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Ignores host_trigger(), when host component is
configured in one shot copy mode. In such mode
the DMA is started every time in copy and stopped
automatically.
Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Changes component's copy attribute from bool to
enum, which makes it extendable. Now we can add
additional copy types and implement each component's
functionality based on selected type.
Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
I've removed PLAFORM_HDA_BURST_SIZE define since it is the
same as HDA_DMA_COPY_ALIGNMENT. In trace functions we
can retrieve alignment by using dma_get_attribute()
dma function.
Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
HDA_DMA_ALIGNMENT and HDA_COPY_ALIGNMENT are not platform
specific. I've moved them from specific platform.h files to
hda-dma.c.
Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
Seppo Ingalsuo