OrgACRN
/
sof
mirror of https://github.com/thesofproject/sof.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Cmocka: Volume: Increase test coverage for S24_LE output format 

This patch adds check for sample to not exceed S24_LE range that
could happen in int32_t type storage. The existing check for
abs(delta) > 1 does not cover such case if e.g. the reference
volume code would output e.g. INT24_MAX and the FW component
INT24_MAX + 1.

Similar check is added for every reference volume function that
outputs S24_LE format.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This commit is contained in:
Seppo Ingalsuo 2019-07-08 14:28:07 +02:00 committed by Tomasz Lauda
parent 27cdfbdb40
commit 34d0db94be
1 changed files with 24 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
test/cmocka/src/audio/volume/volume_process.c
View File

@ -203,6 +203,7 @@ static void verify_s16_to_sX(struct comp_dev *dev, struct comp_buffer *sink,
const int16_t *src = (int16_t *)source->r_ptr;
const int32_t *dst = (int32_t *)sink->w_ptr;
double processed;
int32_t dst_sample;
int32_t sample;
int channels = dev->params.channels;
int channel;
@ -228,9 +229,14 @@ static void verify_s16_to_sX(struct comp_dev *dev, struct comp_buffer *sink,
processed = INT32_MIN;
sample = ((int32_t)processed) >> shift;
delta = dst[i + channel] - sample;
dst_sample = dst[i + channel];
delta = dst_sample - sample;
if (delta > 1 || delta < -1)
assert_int_equal(dst[i + channel], sample);
assert_int_equal(dst_sample, sample);
if (shift && (dst_sample < INT24_MIN ||
dst_sample > INT24_MAX))
assert_int_equal(dst_sample, sample);
}
}
}
@ -281,6 +287,7 @@ static void verify_s24_to_s24_s32(struct comp_dev *dev,
const int32_t *src = (int32_t *)source->r_ptr;
const int32_t *dst = (int32_t *)sink->w_ptr;
double processed;
int32_t dst_sample;
int32_t sample;
int channels = dev->params.channels;
int channel;
@ -304,9 +311,14 @@ static void verify_s24_to_s24_s32(struct comp_dev *dev,
processed = INT32_MIN;
sample = ((int32_t)processed) >> shift;
delta = dst[i + channel] - sample;
dst_sample = dst[i + channel];
delta = dst_sample - sample;
if (delta > 1 || delta < -1)
assert_int_equal(dst[i + channel], sample);
assert_int_equal(dst_sample, sample);
if (shift && (dst_sample < INT24_MIN ||
dst_sample > INT24_MAX))
assert_int_equal(dst_sample, sample);
}
}
}
@ -319,6 +331,7 @@ static void verify_s32_to_s24_s32(struct comp_dev *dev,
double processed;
const int32_t *src = (int32_t *)source->r_ptr;
const int32_t *dst = (int32_t *)sink->w_ptr;
int32_t dst_sample;
int32_t sample;
int channels = dev->params.channels;
int channel;
@ -342,9 +355,14 @@ static void verify_s32_to_s24_s32(struct comp_dev *dev,
processed = INT32_MIN;
sample = ((int32_t)processed) >> shift;
delta = dst[i + channel] - sample;
dst_sample = dst[i + channel];
delta = dst_sample - sample;
if (delta > 1 || delta < -1)
assert_int_equal(dst[i + channel], sample);
assert_int_equal(dst_sample, sample);
if (shift && (dst_sample < INT24_MIN ||
dst_sample > INT24_MAX))
assert_int_equal(dst_sample, sample);
}
}
}