manifest: fix comments

The top level comment is not totally accurate. The 'project_importer'
attribute, for example, doesn't change.

The comment around 'project_filter' reflects an idea I had but
abandoned so that project filter behavior would be more consistent
with group filter behavior.

Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
This commit is contained in:
Martí Bolívar 2023-06-01 14:02:53 -07:00 committed by Carles Cufí
parent 74f43a95d7
commit 50c316a262
1 changed files with 3 additions and 4 deletions

View File

@ -349,7 +349,8 @@ def _is_imap_ok(imap: _import_map, project: 'Project') -> bool:
return allowed or no_allowlists return allowed or no_allowlists
class _import_ctx(NamedTuple): class _import_ctx(NamedTuple):
# Holds state that changes as we recurse down the manifest import tree. # Holds shared state that we want to pass around as we
# resolve imports.
# The current map from already-defined project names to Projects. # The current map from already-defined project names to Projects.
# #
@ -363,9 +364,7 @@ class _import_ctx(NamedTuple):
# The project filters we should apply while resolving imports. We # The project filters we should apply while resolving imports. We
# try to load this only once from the 'manifest.project-filter' # try to load this only once from the 'manifest.project-filter'
# configuration option. It should not be used after resolving # configuration option.
# imports; instead, the lookup should dynamically use the
# configuration we were passed at construction.
project_filter: ProjectFilterType project_filter: ProjectFilterType
# Deque of group filters from every manifest we import. # Deque of group filters from every manifest we import.