From 50c316a2623cfb76df31e5810b77fe7432b8f961 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mart=C3=AD=20Bol=C3=ADvar?= Date: Thu, 1 Jun 2023 14:02:53 -0700 Subject: [PATCH] manifest: fix comments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The top level comment is not totally accurate. The 'project_importer' attribute, for example, doesn't change. The comment around 'project_filter' reflects an idea I had but abandoned so that project filter behavior would be more consistent with group filter behavior. Signed-off-by: Martí Bolívar --- src/west/manifest.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/west/manifest.py b/src/west/manifest.py index 7d7e65b..59494c5 100644 --- a/src/west/manifest.py +++ b/src/west/manifest.py @@ -349,7 +349,8 @@ def _is_imap_ok(imap: _import_map, project: 'Project') -> bool: return allowed or no_allowlists class _import_ctx(NamedTuple): - # Holds state that changes as we recurse down the manifest import tree. + # Holds shared state that we want to pass around as we + # resolve imports. # The current map from already-defined project names to Projects. # @@ -363,9 +364,7 @@ class _import_ctx(NamedTuple): # The project filters we should apply while resolving imports. We # try to load this only once from the 'manifest.project-filter' - # configuration option. It should not be used after resolving - # imports; instead, the lookup should dynamically use the - # configuration we were passed at construction. + # configuration option. project_filter: ProjectFilterType # Deque of group filters from every manifest we import.