The older native_posix board is being deprecated, use native_sim,
which is the future-proof API. Mostly just swap the board target and
change the C API names.
Note the NATIVE_SIMULATOR_IF decoaration on LLVMFuzzerTestOneInput():
that forces the function to be included in the first-stage zephyr.elf
link (otherwise it would be dropped as Zephyr/SOF itself doesn't
reference the entry point) and to be visible as a global symbol to the
libfuzzer instrumentation layer.
Signed-off-by: Andy Ross <andyross@google.com>
There was a problem with test test_102_08_extended_time_check.
The structure ext_system_time_data was sending with wrong size.
Because of this it was not possible to correctly read the value
from the art clock to determine the HH counter.
Signed-off-by: Grzegorz Bernat <grzegorzx.bernat@intel.com>
Add a test to avoid --all breakages like the one in commit
05bfc36dac ("ptl: Add initial PTL configuration"), reported in #9262
See also previous commit.
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
As reported in #9262, this fixes the --all option.
Fixes commit 05bfc36dac ("ptl: Add initial PTL configuration")
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Passing options one by one in .github/workflows/zephyr.yml was becoming
unwieldy. Reduces Windows/Linux duplication. This also makes local
testing easier; less typing and guess work.
This should also help with #9116.
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
OVERLAY_CONFIG has been deprecated by EXTRA_CONF_FILE since Zephyr 3.4
Also fix the corresponding --help string.
Zephyr 3.4 is one year old and has just been end-of-lifed.
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Replaces intermediate variable and redundant comments with a direct
call to return multiband_drc_init_coef function.
Signed-off-by: Shriram Shastry <malladi.sastry@intel.com>
Add helper function to add and remove the additional search path.
Removing the search path is useful for interactive shell usage.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The purpose of this change is to consolidate the files those
belong to the SRC module. This commit only moves the files. The
next commits are fixing the issues caused by the move.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This commit optimizes the division by the speed of sound in the
`theoretical_time_differences` function. By precomputing the fixed-point
reciprocal of the speed of sound, we eliminate the need for a costly
division operation in each iteration.
Additionally, a redundant 'if' statement is removed from the
'tdfb_direction_copy_emphasis' function, simplifying the code.
Signed-off-by: Shriram Shastry <malladi.sastry@intel.com>
Keep context save still disabled for Intel Meteor Lake. This
setting has been used in SOF2.8 and SOF2.9 releases and is used
in Chromebook SOF builds for these platforms. Make the SOF main
default match the releases.
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Combinatorics get hard with all the features, but it's really useful
to be able to test features in isolation.
Signed-off-by: Andy Ross <andyross@google.com>
Change buffer allocation functions to buffer_alloc_range and
buffer_set_size_range. This makes it possible to allocate the buffer even
if the suggested size given in ipc cannot be met.
Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Change buffer allocation functions to buffer_alloc_range and
buffer_set_size_range. This makes it possible to allocate the buffer even
if the suggested size given in ipc cannot be met.
Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Add two new buffer allocation functions buffer_set_size_range and
buffer_alloc_range dedicated to deep buffering. They try to allocate
the largest possible buffer according to the suggested size. If this size
cannot be obtained, it will be reduced step by step until it reaches
the minimum size.
Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Move part of the code responsible for initializing the buffer structure
to the new function buffer_alloc_struct, which will also be used
by a new buffer allocation function.
Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Change name of the buffer_init to buffer_init_stream because it is only
responsible for initiating a stream. Omit the caps parameter because it is
only assigned to a structure field. Assign this field in the function
caller.
Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
FW infrastructure shall support buffering of historic data
from 1ch up to 6 channels 24bit samples in 24bit container.
For this reason, the heap should be extended.Increase HEAPMEM_SIZE
by 0x90000 because for audio format 16000Hz/6ch/24bit
history_buffer_size = 16 * 6 * 3 * 2100s = 604800 bytes (0x93A80)
Signed-off-by: Jaroslaw Stelter <Jaroslaw.Stelter@intel.com>
Add PTL configuration changes required to build FW
for FPGA. After next SOF rebase default target will be
build for RVP, so for FPGA we will use configuration
overlay.
Signed-off-by: Jaroslaw Stelter <Jaroslaw.Stelter@intel.com>
Patch adds PTL configuration basing on MTL
DMIC depends on PM_DEVICE_RUNTIME and PM_DEVICE_POWER_DOMIAN settings.
To effectively enable DMIC these flags must be set.
Additionally DMIC Ownership bit is not supported on ACE 2.0 and ACE 3.0.
Therefore CONFIG_DAI_DMIC_HAS_OWNERSHIP is switched off.
Signed-off-by: Jakub Dabek <jakub.dabek@intel.com>
Due to introducing new platform to sof we need to recognize which
iteration of ace board we are dealing with.
Signed-off-by: Dobrowolski, PawelX <pawelx.dobrowolski@intel.com>
Big rewrite of the core processing code of AEC:
Support both S32 and S16 input and output formats, dynamically
selected at prepare() time based on stream configuration.
Copy/convert data in maximally inlined/unrolled loops, using
cleanly-generated (no duplication!) custom conversion utilities for
each format variant.
Orthogonalize and elaborate the validation code in prepare(). Check
all state for all input/output streams.
Decouple AEC operation from the input stream, filling zeros on
underflow and allowing AEC to run in circumstances where no playback
data exists and to recover when it starts/stops. IPC3 setups can
exploit this now, unfortunately IPC4 always starts connected pipelines
from the host kernel so sees no benefit.
Fix a latency bug with the original code where it would copy the
processed results to the output stream before the call to
ProcessCapture() instead of after, leading to a needless delay. Copy
the results as soon as they are available, if the output buffer backs
up, we'll continue at the next call to process()
Signed-off-by: Andy Ross <andyross@google.com>
Put the AEC tunables inside an if COMP_GOOGLE_RTC_AUDIO_PROCESSING for
hygine. This prevents them from appearing in .config files of SOF
builds where AEC was never enabled at all.
Set MOCK via a default instead of select. Select is unoverridable, it
forces the MOCK to be used whenever COMP_STUBS=y, but it's more
flexible to allow the app to pick and choose which components get
stubbed (STUBS is often set at the platform layer).
Signed-off-by: Andy Ross <andyross@google.com>
On IPC3 pipelines, triggers can arrive at this component due to
changes in the reference pipeline. Those aren't for us, and have the
effect of incorrectly resetting the capture stream if someone stops
playback. Earlier product branches handled this logic in the pipeline
layer, but that never reached SOF main, and it's easier to do here by
just ignoring the event.
On IPC4, triggers never propagate across pipelines (and in any case
dependent pipeline state management happens in the host kernel), so
this becomes a benign noop.
Signed-off-by: Andy Ross <andyross@google.com>
In point of fact the AEC code has never worked on SOF main, and this
code doesn't either. It got left here as new code got added to
support for MTL, and it's just a wart.
Really there's nothing "IPC4ish" at all about the new code at all,
there's no reason a single code path can't be used for both, the
process/source/sink APIs are identical. The new code doesn't work
with legacy builds, mind you. But it will. Remove the stuff that
will never be used.
Signed-off-by: Andy Ross <andyross@google.com>
The internals of the AEC library are floating point already. If we're
going to support using the float variant of the API, we should use it
always to avoid all the complexity.
Signed-off-by: Andy Ross <andyross@google.com>
This technique doesn't work. The ID returned by get_source_id() is
not fixed by topology. Those numbers are derived from a component ID
allocated in the Linux kernel via ida_alloc(). The specific values
will depend on the state and history of the allocator, we can't
compare them via numerical identity here in the firmware even if they
happen to work right now due to topology ordering.
Fall back to the older technique of checking whether the input source
is on the same pipeline as the AEC component to determine if it's the
microphone input.
Signed-off-by: Andy Ross <andyross@google.com>
The operation of the AEC component uses a single buffer as an internal
heap. This is very large, over half the available SRAM at component
creation time on MTL. That's just a poor fit for the heap. It would
be trivial to create a fragmentation scenario by creating/destroying
components (which happens under user control all the way out in Linux
userspace!) where AEC can't initialize and microphone input breaks.
Longer term we can look at moving this usage back to the heap by
integrating the component's internal allocations with the SOF/Zephyr
heap (which is quite performant), allowing it to make fine-grained
allocations which will work more robustly.
Signed-off-by: Andy Ross <andyross@google.com>
There's a race posiibility in DP when stopping a pipeline:
- dp starts processing
- incoming IPC - pause the pipeline. IPC has higher priority
than DP, so DP is preempted
- pipeline is stopping, module "reset" is called. Some of resources
may be freed here
- when IPC finishes, DP thread continues processing
Sollution: wait for DP to finish processing and terminate DP thread
before calling "reset" method in module
To do this:
1) call "thread cancel" before calling "reset"reset
2) modify "thread cancel" to mark the thread to terminate and
execute k_thread_join()
3) terminated thread cannot be restarted, so thread creation must be
moved from "init" to "schedule". There's no need to reallocate memory
zephyr guarantees that resources may be re-used when a thread
is terminated.
Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
Update zephyr main to support PTL target for dai/ssp
e452bc36a6d9 dai: ssp/ptl: Add missing definition in PTL
Signed-off-by: Dobrowolski, PawelX <pawelx.dobrowolski@intel.com>
Free the memory allocated for tplg base and available input/output
formats when the topology is freed.
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
The controls names for IIR, FIR need to be same as in
sof-hda-generic for UCM to find the controls and set up
the components for processing.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Virtual index value for I2S on PTL contains two information:
- time slot group index : 4
- i2s instance : 4
In order to correctly configure the dai api, both of the above
values should be retained.
Update zephyr branch to commit:
a2386efbce1 drivers: ssp: update SSP driver to support Intel ACE30 PTL
Signed-off-by: Damian Nikodem <damian.nikodem@intel.com>
This commit introduces a new constant 'I2S_VER_30_PTL' that describes
specific I2S blob configurations for Intel ACE30 PTL.
Signed-off-by: Damian Nikodem <damian.nikodem@intel.com>
Legacy API that is not using module_adapter is now depreciated,
but there are still some modules that use it. So all common code
must work properly with both types of modules.
This commit is fixing crash in bind operation when binding
a legacy module. There also some comments added in potentially
similar places, but where legacy modules cannot be used.
Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
Expose the new pipeline_id field in sof_audio_stream_params to a
cleaner sink/source API for use by module code. Longer term this may
want to be indirected by newer backends.
Signed-off-by: Andy Ross <andyross@google.com>
The pipeline_id has historically been part of the comp_buffer struct,
but that is being deprecated as a public API. So move it down into
the contained sof_audio_stream_params struct where it can be found by
new style sink/source code.
Note that the actual value of the pipeline ID is a little ambiguous:
on IPC3, the buffer is defined by the user in the .tplg file as part
of a specific pipeline with a known ID. With IPC4 topology, the
buffers are implicitly created and will be assigned the ID of their
source (!) component. It is legal to define a connection across two
pipelines, and there's no ability here to recover both pipeline IDs.
Signed-off-by: Andy Ross <andyross@google.com>
The current SOF architecture splits a "module" across two structs, the
legacy comp_dev and a newer struct processing_module. The latter
contains a pointer to the former, but in many places existing code has
needed a backpointer to recover the module from a component.
So far this has abused the drvdata mechanism to store this as a void*,
but that's fragile as many components are already (!) using drvdata
for other purposes and will clobber the setting. The fact that it
worked is seeming just by luck. That pointer is for the exclusive use
of the comp_driver code associated with a component to store its own
data. We can't be touching it from the global module code.
Just give the pointer a properly-typed field of its own and make sure
the two are initialized in tandem. Longer term, SOF really needs to
fix this bifurcation and unify the two structs.
Signed-off-by: Andy Ross <andyross@google.com>
This is dead code: just a wrapper around module_adapter_new(), which
is a public API already in use. Presumably a forgotten relic.
Remove.
Signed-off-by: Andy Ross <andyross@google.com>
Andy Ross