The include of dai-zephyr.h causes IPC4 testbench build to
fail due to further include of Zephyr headers. Since the
copier_generic.c build is not needing it, it can be removed.
The HiFi build version copier_hifi.c is already without
this include.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The new copier gain feature needs this structure. The added
member is copied directly from dai-zephyr.h. Testbench IPC4
is using legacy DAI definitions instead of Zephyr DAI to avoid
to include a lot of difficult dependencies. Build of testbench
fails if dai-legacy.h does not contain this.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Includes the following changes potentially relevant to SOF:
155f3f3ba688 west_commands: sign: add imx95 to target list
01754956de29 boards: nxp: imx95_evk: add rimage support for m7 ddr variant
848907c0f81d soc: imx: imx95: enable cache management for M7
f3e870dfa5d4 boards: nxp: imx95_evk: add edma and sai nodes
Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
This commit makes all components use API for accessing
the previous/next component
pipeline code, like module adapter or ipc helpers was
omitted intentionally
Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
This commit makes all components use API for accessing
the previous/next component
pipeline code, like module adapter or ipc helpers was
omitted intentionally
Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
A typical action for a component is to check if a
prev/next component exists and is ready to provide/consume data:
if (buf->sink && buf->sink.state == STATE_....)
In pipeline 2.0 it should be done by a state
of sink/src API, but for now a helper for the operation
is provided by this commit.
In case the component does not exists, a special state
COMP_STATE_NOT_EXIST is introduced
Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
Fix silent overflow in the fuzzer. 255 is clearly << 65536 so that means
we are not able to exercise the full buffer. But upon further inspection
its clear that numbers are a minimum truncated if not rolling over based
on the code in the size_t to uint8_t conversions.
This was validated by converting the type temporarily to signed and
observing the fuzzer using a negative index.
Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
All fuzzing infra has moved to the posix platform. The corpus is not
being deployed, and is soon to be modified anyways. Its also missing
IPC4 in the corpus.
Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
Always append the UUID to the end of the module init IPC data and use
that to look up the component driver instead of using the hardcoded UUID
map. This will make it easier to support new processing elements with
the plugin/testbench. Also, modify the get/set_large_config handlers to
use the component driver set in the dev instead of looking it up again.
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Sometimes it can help to see how the chunks arrive from firmware when
comparing logs with the kernel for example.
The --mark-chunks flag will add a marker for each new chunk that is printed
with a running number and the size of the given chunk, for example:
--- Chunk #604 start (size: 652) ---
[ 0.000000] <inf> init: print_version_banner: FW ABI 0x301d001 DBG ABI 0x5003000 tags SOF:v2.5-stable-branch-2772-g76e650e56598-dirty zephyr:v3.7.0-2127-ge7c84756087f src hash 0x4ff3fd64 (ref hash 0x4ff3fd64)
*** Booting Zephyr OS build v3.7.0-2127-ge7c84756087f ***
[ 0.000000] <inf> main: sof_app_main: SOF on intel_adsp
[ 0.000000] <inf> main: sof_app_main: SOF initialized
[ 0.000000] <inf> ipc: ipc_cmd: rx : 0x44000000|0x31400008
[11896.403666] <inf> ipc: ipc_cmd: tx-reply : 0x64000000|0x31400008
[11896.404076] <inf> ipc: ipc_cmd: rx : 0x44000000|0x3060004c
[11896.404093] <inf> ipc: ipc_cmd: tx-reply : 0x64000000|0x3060004c
--- Chunk #605 start (size: 196) ---
[11896.969658] <inf> ipc: ipc_cmd: rx : 0x11000005|0x0
[11896.969671] <inf> pipe: pipeline_new: pipeline new pipe_id 0 priority 0
[11896.969685] <inf> ipc: ipc_cmd: tx-reply : 0xb1000000|0x0
--- Chunk #606 start (size: 2236) ---
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
This commit addresses the limitation in the schedulers_info_get function
where scheduler information could only be retrieved for the primary
core. The updated implementation now validates the core_id against the
number of configured cores (CONFIG_CORE_COUNT) and initiates an IPC
process on the requested core if it is not the current core.
Changes include:
- Adding a check to ensure the core_id is within the valid range.
- Calling ipc4_process_on_core to handle IPC processing on secondary
cores.
- Returning appropriate IPC4 error codes based on the result of
ipc4_process_on_core.
Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
Add methods to update gain coefficients in runtime by handling
DMA CONTROL IPC message being sent to specific dai device based
on provided node id.
Check for unity gain flag.
Signed-off-by: Ievgen Ganakov <ievgen.ganakov@intel.com>
This patch addresses the issue of inconsistent error code usage in the
base_fw.c file, where a mix of POSIX and IPC4 error codes was previously
present.
The IPC4 error codes are now used consistently throughout the file,
ensuring that the error handling is aligned with the IPC4 protocol
expectations. The changes include replacing POSIX error codes such as 0,
-EINVAL, and -ENOMEM with their corresponding IPC4 status codes
IPC4_SUCCESS, IPC4_ERROR_INVALID_PARAM, and IPC4_OUT_OF_MEMORY,
respectively. This standardization helps to avoid confusion and
potential bugs that can arise from the mixed usage of different error
code conventions.
Signed-off-by: Tomasz Leman <tomasz.m.leman@intel.com>
Since with module adapter the component type from init IPC
is no more SOF_COMP_MUX or SOF_COMP_DEMUX but
SOF_COMP_MODULE_ADAPTER, the mux mode check needs to be change.
The type is set in init() based on which init function was
used.
All checks for dev->ipc_config.type are changed to check of
cd->comp_type. The set of type in mux_ipc4.c is removed.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The change done in commit b53573a15c
("ipc3: override type field once comp_driver found") expects
the component type via init IPC to be the same as module
register sets (SOF_COMP_MODULE_ADAPTER).
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
On initialization we use rzalloc which 0s out all fields. We later call
audio_stream_recalc_align which uses the frame_bytes to align the buffer.
This is problematic as clz() is passed the size of the frame size which
is 0 since channel is 0 and passing 0 to clz is undefined behaviour.
Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
The SOF perf_cnt.h provides a simple performance counter interface that
is used in SOF to track performance at audio module and pipeline level.
Majority of the implementation is RTOS agnostic, relying on
sof_cycle_get_64() to sample platform clock, and timer_get_system() for
CPU clock, both defined in rtos/timer.h. There is however some
conditional rules for Zephyr to use timing_counter_get() if SOF is built
with CONFIG_TIMING_FUNCTIONS=y.
The amount of RTOS variation does not seem to warrant branching the
whole perf_cnt.h to RTOS layer. Move perf_cnt.h back to application
interface, so the single implementation can be shared.
Link: https://github.com/thesofproject/sof/issues/9015
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Implements a gui and tui that can be used to easily demonstrate SOF
on target HW. See README and README-dev for more information on
functionality and purpose.
Signed-off-by: Alexander Brown <alex.brown.3103@gmail.com>
The utils is a better description of the purpose of the functions
in these files. There's no change to functionality.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch adds topology parsing and common functions versions
for IPC4.
Due to dai_get_init_delay_ms() implementation in IPC4 build
the file component is changed internally to copier to provide
the DAI data struct. The change is common for both IPC3 and IPC4
though copier is not usually used with IPC3 systems. Since it
works the same solution is used. The file state retrieve is changed
because the file component data is placed deeper into the
structures.
Due to IPC4 scheduling of pipelines the file component is added
a timeout. A file component sets timeout status if there has
been three copy operations with no data to process. The timeout
and EOF are used to end cleanly the test run.
The library_defconfig still has CONFIG_IPC_MAJOR_4=n. The add
of build type select to scripts/rebuild-testbench.sh is further
work. Also the IPC4 testbench in this state is not well usable
with only one component supported as process component and
without byte control set up algorithms.
Test run with DC blocker is possible this way:
tools/testbench/build_testbench/install/bin/testbench
-r 48000 -R 48000 -c 2 -n 2 -b S32_LE -p 1,2
-t tools/build_tools/topology/topology2/development/
sof-hda-benchmark-dcblock32.tplg
-i in.raw -o out.raw
Also sof-hda-benchmark-gain32.tplg can be run.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This change avoids a segfault. Topologies may contain
non-supported PCMs such as HDMI and if pipelines are not
restricted with -p A,B,C,.. option file might get set up
without filename.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The helper functions are moved from testbench.c to common_test.c
and common_test_ipc3.c as preparation to add IPC4 support.
The file components are looked up in test setup to arrays to ease
finding them in test run and control ending the test.
The parse string for command getopt() is fixed to match the
supported options.
The testbench parameter struct is changed to dynamically allocated
and zeroed by calloc(). It also avoids issues found with valgrind
about uninitialized.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Prefix macros with TB and add TESTBENCH to headers single time
include control macros. Especially ifndef _TRACE_H is in risk
to conflict with possible other headers.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The build of testbench IPC4 with xt-clang fails with this error:
sof/src/audio/tdfb/tdfb_ipc4.c:31:37: error:
field 'module_data' with variable sized type
'struct sof_ipc4_notify_module_data' not at the end of a struct or
class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end]
sof/src/audio/tdfb/tdfb_ipc4.c:32:38: error:
field 'control_msg' with variable sized type
'struct sof_ipc4_control_msg_payload' not at the end of a struct or
class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end]
The issue is fixed with use of struct pointers to IPC message
msg_module_data and msg_payload to prepare the message template.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The crossover_init_output_pins() function is changed to static.
This change avoids build error:
sof/src/audio/crossover/crossover_ipc4.c:32:5:
error: no previous prototype for ‘crossover_init_output_pins’
[-Werror=missing-prototypes]
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Components initialize in testbench needs these headers. Adding
these allows load of to the components when found in topology.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This addition allows to load file components for DAI
and host copier replacement for testbench. DC blocker
is added as process component to allow testing of this
component as example. Support for other processing
components will need a new solution to pass the UUIDs
over IPC messages instead of the 8-bit index value.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Warnings are errors in testbench build. This change avoids error:
sof/src/ipc/ipc4/helper.c:761:19:
error: unused function 'process_dma_index' [-Werror,-Wunused-function]
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This prevents the IPC4_FAILURE since there is no parallel
execution in scheduler and pipelines with this IPC request
and respond step.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The use of size_t needs include of stddef.h. Without this
there is build error in copier_hifi.c:
sof/src/include/ipc4/alh.h:70:15: error: unknown type name ‘size_t’
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This avoids compile error in copier.c:
sof/src/audio/copier/copier.c:692:34:
error: ‘struct dai_data’ has no member named ‘chmap’
and in copier-dai.c:
sof/src/audio/copier/copier_dai.c:550:34:
error: ‘struct dai_data’ has no member named ‘channel_copy’
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This fixes build issues
In file included from tools/testbench/common_test.c:5:
src/platform/library/include/platform/lib/ll_schedule.h:22:51:
error: ‘enum task_state’ declared inside parameter list will not
be visible outside of this definition or declaration [-Werror]
In file included from tools/testbench/common_test.c:16:
tools/testbench/build_testbench/sof_ep/install/include/sof/
schedule/ll_schedule.h:40:5:
error: conflicting types for ‘schedule_task_init_ll’
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
chmap is a parameter common for all types of buffers, should be
accessible through sink/src api, so it needs to be kept in
sof_audio_stream_params
an API inroduced for accessing the parameter
Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
walking flag is not really needed for data buffering,
rather for pipeline iteration procedures, so it should
not be in sof_audio_buffer structure. But before in order
to make possible usage of other buffer types than comp_buffer
before pipeline2.0 is ready, it must be kept there.
Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
hw_params_configured is a flag indicating that a buffer params has
been already set, and should be kept in the same structure as the
params themselves
this commit moves hw_params_configured to sof_audio_stream_params
and introduces API to handle the flag
Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
is_shared is a flag indicating that a buffer is shared
between cores.
This property is common for all types of audio buffers and
should be kept in a base structure
Signed-off-by: Marcin Szkudlinski <marcin.szkudlinski@intel.com>
SOF telemetry performance measurement tools use the same window 3 as the
DSP winstream log backend, so the two cannot be enabled at the same
time.
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
SOF telemetry performance measurement tools use the same window 3 as the
DSP winstream log backend and the latter is enabled in the shell
overlay. Disable the conflicting feature.
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Seppo Ingalsuo