.github: independent strict and non-strict runs of check patch

This makes the difference between "strict" and regular failures very
clear.

Stopping after non-strict failures is misleading, it can give the wrong
impression that there are very few warnings left.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This commit is contained in:
Marc Herbert 2022-06-03 14:46:03 -07:00 committed by Liam Girdwood
parent 46a5de6f49
commit eaf95695f6
1 changed files with 11 additions and 5 deletions

View File

@ -17,6 +17,12 @@ on: [pull_request]
jobs: jobs:
checkpatch: checkpatch:
runs-on: ubuntu-20.04 runs-on: ubuntu-20.04
strategy:
fail-fast: false
matrix:
strictness: [null, --strict]
env: env:
PR_NUM: ${{github.event.number}} PR_NUM: ${{github.event.number}}
# TODO: reduce duplication with scripts/sof-*-commit-hook.sh # TODO: reduce duplication with scripts/sof-*-commit-hook.sh
@ -41,12 +47,12 @@ jobs:
# show what we got # show what we got
git --no-pager log --oneline --graph --decorate --max-count=50 git --no-pager log --oneline --graph --decorate --max-count=50
- name: normal checkpatch - name: checkpatch
run: .github/workflows/checkpatch_list.sh ${CHK_CMD_OPTS} < PR_SHAs.txt env:
STRICTNESS: ${{ matrix.strictness }}
- name: checkpatch --strict
run: .github/workflows/checkpatch_list.sh ${CHK_CMD_OPTS} run: .github/workflows/checkpatch_list.sh ${CHK_CMD_OPTS}
--strict < PR_SHAs.txt ${STRICTNESS} < PR_SHAs.txt
yamllint: yamllint:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps: