From eaf95695f6c3f68a910d24ab364e522eac992666 Mon Sep 17 00:00:00 2001 From: Marc Herbert Date: Fri, 3 Jun 2022 14:46:03 -0700 Subject: [PATCH] .github: independent strict and non-strict runs of check patch This makes the difference between "strict" and regular failures very clear. Stopping after non-strict failures is misleading, it can give the wrong impression that there are very few warnings left. Signed-off-by: Marc Herbert --- .github/workflows/codestyle.yml | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/.github/workflows/codestyle.yml b/.github/workflows/codestyle.yml index 6c0577a09..ad8d299e1 100644 --- a/.github/workflows/codestyle.yml +++ b/.github/workflows/codestyle.yml @@ -17,6 +17,12 @@ on: [pull_request] jobs: checkpatch: runs-on: ubuntu-20.04 + + strategy: + fail-fast: false + matrix: + strictness: [null, --strict] + env: PR_NUM: ${{github.event.number}} # TODO: reduce duplication with scripts/sof-*-commit-hook.sh @@ -41,12 +47,12 @@ jobs: # show what we got git --no-pager log --oneline --graph --decorate --max-count=50 - - name: normal checkpatch - run: .github/workflows/checkpatch_list.sh ${CHK_CMD_OPTS} < PR_SHAs.txt - - - name: checkpatch --strict + - name: checkpatch + env: + STRICTNESS: ${{ matrix.strictness }} run: .github/workflows/checkpatch_list.sh ${CHK_CMD_OPTS} - --strict < PR_SHAs.txt + ${STRICTNESS} < PR_SHAs.txt + yamllint: runs-on: ubuntu-latest steps: