Commit Graph

2016 Commits

Author SHA1 Message Date
Pastorcici, Mariano-paulX c50658ae6b feat: [common] Enable PCIe resizable BAR support
This commit adds support for PCIe resizable BARsupport.
The feature can be enabled by setting PcdResizableBarSupport
for the board build script and its disabled by default.

Signed-off-by: pastorcx <mariano-paulx.pastorcici@intel.com>
2024-09-09 10:30:57 -07:00
Vincent Chen 32704b0653 feat: [Common] TCC tools related code clean up
Removed the source code related to TCC tools
including DSO switch, SWSRAM switch, TCC subregions
TCC Error Log switch, RTCM, RTCT
The code change applies on TGL/EHL/ADL/RPL/MTL

Signed-off-by: Vincent Chen <vincent.chen@intel.com>
2024-09-06 07:07:57 -07:00
Biswas Arghya 7ac5760e2d feat: [AZB] Update AZB SBL version to 1.4
Update the AZB SBL version to 1.4.

Signed-off-by: Biswas Arghya <arghya.biswas@intel.com>
2024-09-06 07:03:40 -07:00
Biswas Arghya 03988e9580 feat: [AZB] Update Microcode git hash for 0x09
Update the Microcode git hash for m_40_906a4_00000009.mcb.

Signed-off-by: Biswas Arghya <arghya.biswas@intel.com>
2024-09-06 07:03:40 -07:00
Biswas Arghya c15510532d feat: [AZB] Update FSP git commit hash
Update the FSP git commit hash to 4dfe5cb91bfe415c6b0e4488bd4d0cb407d06e82

Signed-off-by: Biswas Arghya <arghya.biswas@intel.com>
2024-09-06 07:03:40 -07:00
costel-ignat b61700defd feat:[ADL-P] Add i2c library
Signed-off-by: costel-ignat <costel.ignat@intel.com>
2024-09-05 07:34:59 -07:00
bejeanmo 407cca9e68
fix: Source Level Debug breaks in X64. (#2283)
DebugAgentLib was using its own IDT Entry structure definition that
didn't adjust for x64. Removed this definition and switched to built
in definition from ProcessorBind.h which does adjust for architecture
correctly.

Signed-off-by: Bejean Mosher <bejean.mosher@intel.com>
2024-09-04 16:52:35 +08:00
tsaikevin 94ac64c70e
[ADLN] Improve eMMC performance (#2281)
* fix: [ADLN] Prevent to enumerate RP25 and above

PCIe RP25 and above are supported only when PCH seriese is PCH S.
Prevent to enumerate RP25 and above to address resource conflict with eMMC.

Signed-off-by: Kevin Tsai <kevin.tsai@intel.com>

* fix: [ADLN] Update eMMC driver strength

Update eMMC driver strength 40Ohm for CRB.
Improve performance benchmark result.

Signed-off-by: Kevin Tsai <kevin.tsai@intel.com>

---------

Signed-off-by: Kevin Tsai <kevin.tsai@intel.com>
2024-09-03 19:28:16 -07:00
tsaikevin e609296abe
fix: [ARLS] Fix coverity issues (#2279)
Address following coverity issues
1. Integer Overflow or Wraparound (CWE 190)
2. NULL Pointer Dereference (CWD 476)

Signed-off-by: Kevin Tsai <kevin.tsai@intel.com>
2024-08-29 09:31:09 +08:00
Stanley Chang 78227a9020 fix: [ADL-P] replace magic numbers with pimux def
The commit replaces the magic numbers with the newly added pinmux define.

Signed-off-by: Stanley Chang <stanley.chang@intel.com>
2024-08-28 17:18:40 -07:00
Stanley Chang 6f1b513574 fix: [ADL-P] add missing pinmux definitions
Some important pinmux definitions are missing, e.g.,
Both H4/H5 and E12/E13 are for I2C0.

Signed-off-by: Stanley Chang <stanley.chang@intel.com>
2024-08-28 17:18:40 -07:00
tsaikevin b1c66b6e36
fix: [Common] Fix coverity issues CWE 188 (#2277)
Address Reliance on Data/Memory Layout (CWE 188)

Signed-off-by: Kevin Tsai <kevin.tsai@intel.com>
2024-08-29 06:58:03 +08:00
tsaikevin e40e8679be
fix: [Common] Fix coverity issues for x64 build (#2276)
Address following coverity issues
1. Integer Overflow or Wraparound (CWE 190)
2. Unexpected Sign Extension (CWD 194)

Signed-off-by: Kevin Tsai <kevin.tsai@intel.com>
2024-08-27 11:54:51 -07:00
randylintw 385cd271aa
fix: [MCL] HDA Verb table set fail (#2272)
The debug fsp report:
  SDI#0: No matching HD-Audio codec verb table found for codec (0x10EC0897).
fix and can see
  SDI#0: Detected HD-Audio Codec 0x10EC0897 rev 0x04
  Found Verb Table for VendorID 0x10EC, DeviceId 0x0897, RevisionID 0xFF (SDI:FF, size: 4 dwords)

Verified on MCL

Signed-off-by: Randy <randy.lin@intel.com>
2024-08-27 14:47:14 +08:00
Sabryna 4b2e125d5e
fix:[ARLH/U] memory SPD data amendment (#2273)
adding the SPD data table into FSPM file

Signed-off-by: Syahirah Sabryna <nur.syahirah.sabryna.mohmad@intel.com>
2024-08-26 18:12:32 +08:00
Sabryna 0e742cd4b8
feat:[ARLU] enabling ARLU board configuration (#2271)
update the StitchIfwi_arlu.py separately due to different ACM used

Signed-off-by: Syahirah Sabryna <nur.syahirah.sabryna.mohmad@intel.com>
2024-08-26 17:35:11 +08:00
Sabryna 7357a9b615
feat: [ARLH/U] Adding RVP & LP5 binaries stitch configuration (#2268)
Update the option for RVP & LP5 while stitching, add "-o rvp" or "-o lp5" at the end of command

Signed-off-by: Syahirah Sabryna <nur.syahirah.sabryna.mohmad@intel.com>
2024-08-22 11:13:45 +08:00
Sabryna 29350127d7
feat: [ARLH/U] Enable LP5 support (#2267)
adding support for MTL_P_LPDDR5_T4_RVP board

Signed-off-by: Syahirah Sabryna <nur.syahirah.sabryna.mohmad@intel.com>
2024-08-22 10:18:38 +08:00
Randy 7392c630b3 feat: [MTL] Enable McLaren Island basic boot
Build command:
  python buildloader.py  build mtl
Stitch commmand:
  python Platform\MeteorlakeBoardPkg\Script\StitchIfwi.py  -b fvme
  -s Outputs\mtl\Stitch_Components.zip
  -c Platform\MeteorlakeBoardPkg\Script\StitchIfwiConfig_mcl.py
  -w \Stitchifwi_components_mtl -p mtlp -d 0xAA00001F

Verified base boot with win11/ubuntu 24 on Intel McLaren Island Reference Design Board.

Know issues:
* Dp++, HDMI 2.1 not enabling.
* S0ix not enabling.
* USB 3.2 stack CON with usb4-c not enabling.

Signed-off-by: Randy <randy.lin@intel.com>
2024-08-21 08:35:23 -07:00
Vincent Chen cb83f60f62 fix: [EHL] Windows cannot enable WOL for PCH GbE
The "Allow this device to wake the computer" option
(Device Manager => Network adaptors => Properties of PCH GbE
 => Power Management) is grayed out in Windows.
Added the "_PRW" ACPI method to enable the feature.

Signed-off-by: Vincent Chen <vincent.chen@intel.com>
2024-08-21 08:33:31 -07:00
Stanley Chang 5075639596 fix: [ASL] remove deprecated PLATFORM_ASL
The PLATFORM_{NAME} macro is dynamically defined by BuildUtility.py, which
is based on the board file name. Since ASL has been merged into ADL-N, the
PLATFORM_ASL macro has become obsolete and is no longer valid. This commit
removes all instances of the deprecated PLATFORM_ASL.

Additionally, this commit addresses an issue where PLATFORM_ADLN was not
defined in Stage1ABoardInitLib.c during the build process for ADL-N. The cause
was that ConfigDataStruct.h was not included.

Signed-off-by: Stanley Chang <stanley.chang@intel.com>
2024-08-21 08:32:40 -07:00
Randy 4cf45340a1 Fix: disable opt build cause error
error log:
MdePkg\Library\BaseFdtLib\libfdt\libfdt\fdt_rw.c(194) : error C2220: the following warning is treated as an error
MdePkg\Library\BaseFdtLib\libfdt\libfdt\fdt_rw.c(111) : warning C4706: assignment within conditional expression
MdePkg\Library\BaseFdtLib\libfdt\libfdt\fdt_rw.c(194) : warning C4706: assignment within conditional expression
MdePkg\Library\BaseFdtLib\libfdt\libfdt\fdt_rw.c(89) : error C2220: the following warning is treated as an error

ref: https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4706?view=msvc-170

Signed-off-by: Randy <randy.lin@intel.com>
2024-08-21 08:29:42 -07:00
Sindhura Grandhi 50c41451a7 [ARL]: Assign CPU Name for Arrowlake SKUs
Signed-off-by: Sindhura Grandhi <sindhura.grandhi@intel.com>
2024-08-21 08:27:06 -07:00
Sabryna 8655f053c6
fix: [ARLH] Fix watchdog hang on system (#2263)
Enabling the WatchDog & TcoTimer options to avoid hang on system

Signed-off-by: Syahirah Sabryna <nur.syahirah.sabryna.mohmad@intel.com>
2024-08-20 12:59:05 +08:00
skasim 3eafd13581
feat: [ADLS] Update IPU2024.4 Release (#2261)
BIOS version is NEX ADL-S IPU 2024.4 (5045_03) FSP
FSP version is 0C00D550
platform version is 1.7
Microcode Files are: ['m_07_90672_00000036.pdb', 'm_80_906a3_00000434.pdb', 'm_11_b06e0_00000017.pdb']

Signed-off-by: samihahkasim <samihah.kasim@intel.com>
2024-08-20 11:15:56 +08:00
tsaikevin fcc847034c
feat: [ARL] Adjust MTRR to cover full flash (#2260)
This patch adjusted MTRR settings during PostTempRamInit notification to cover full flash
code region if Boot Guard profile 0 is used or Fast Boot is enabled.

Signed-off-by: Kevin Tsai <kevin.tsai@intel.com>
2024-08-16 15:34:40 +08:00
tsaikevin 0db19df9b3
fix [ARL] Check EC device existence on board (#2258)
Check EC device existence before sending command.
The patch prevents waiting for timeout when reading BoardId.

Signed-off-by: Kevin Tsai <kevin.tsai@intel.com>
2024-08-16 11:47:03 +08:00
Guo Dong 13a07c93f5
ARL: Update FSP-T UPD code region (#2257)
The FSP UPD code region should try to cover SBL Stage1A and Stage1B
with a minimum region size. It would impact MTRR settings before memory
init and the MTRR settings would be updated after FspTempRamExit().

Reduce the code region size could improve boot performance for some
SKUs.

Signed-off-by: Guo Dong <guo.dong@intel.com>
2024-08-16 11:45:31 +08:00
bejeanmo e3dfb721bb
fix: GenContainer.py not setting default auth type correctly (#2250)
When no auth parameter is specified on the command line, gen_layout
chooses auth type based on provided key, but this does not get correctly
applied to the monolithic signing component because of an order of
operations issue.

Signed-off-by: Bejean Mosher <bejean.mosher@intel.com>
2024-08-15 13:02:37 -04:00
Vincent Chen f42e13e22c feat: [EHL] enable eMMC HS400 mode by default
modified the EMH4 object in ACPI PCH NVS area

Signed-off-by: Vincent Chen <vincent.chen@intel.com>
2024-08-15 08:15:39 -07:00
Stanley Chang 7bb6216b30 fix: [Tool] BaseTools built with specified VS on Windows
When multiple versions of Visual Studio (VS) were installed, the BaseTools
would be built with the latest version, regardless of user preference
(i.e., specified by the "-t" option). This behavior was incorrect for users
needing to build with a specific VS. This commit addresses the issue by aligning
the BaseTools to build with the user-specified version of VS.

Test steps:
  0. Two versions of VS are installed: VS2017 and VS2022
  1. Default build: python BuildLoader.py build tgl
  2. Build with specific version: python BuildLoader.py build tgl -t vs2022

Signed-off-by: Stanley Chang <stanley.chang@intel.com>
2024-08-15 07:22:43 -07:00
Antara Borwankar 224b2f4c5a fix:[ARL-H] Added BiosRedAssistance setting in stitch config
BiosRedAssistance setting is added to stitch config.
By default it is disabled. Enable for FW resiliancy.

Signed-off-by: Antara Borwankar <antara.borwankar@intel.com>
2024-08-12 16:56:05 -07:00
ongeelim faf6b82b98
fix: [ARL] Fix SBL build issue in Linux (#2251)
Accidental removal of EFIAPI from CalculateRelativePower function in
Stage2BoardInitLib.c caused GCC to issue incompatible-pointer-types error.
This patch addresses the build issue.

Signed-off-by: Ong Ee Lim <ee.lim.ong@intel.com>
2024-08-12 09:35:15 -04:00
tsaikevin 69b1471868
fix: [Common] Initial Security Policy (#2248)
Add initial SECURITY.md file using OS PDT template

Signed-off-by: Kevin Tsai <kevin.tsai@intel.com>
2024-08-08 13:30:59 -04:00
Sabryna 9173111b86
feat: [ARLH] Enable UPDs to follow SiConfigData (#2249)
PchLockDownBiosLock & PchLockDownGlobalSmi follow board SiCfgData

Signed-off-by: Syahirah Sabryna <nur.syahirah.sabryna.mohmad@intel.com>
2024-08-08 16:41:19 +08:00
Sabryna e318f1349b
fix: [ARL] correcting PlatformDebugOption UPD (#2247)
PlatformDebugConsent -> PlatformDebugOption

Signed-off-by: Syahirah Sabryna <nur.syahirah.sabryna.mohmad@intel.com>
2024-08-02 16:01:17 +08:00
randylintw 808eb64f89
fix: [MTL] Debug fsp log go to wrong port (#2243)
Issue: fsp debug log goes to EC port on RVP.
This fix also require FSP update to BIOS version 4053_51 or newer.

Signed-off-by: Randy <randy.lin@intel.com>
2024-08-02 15:47:27 +08:00
kokweich 78b7e09f9a
fix: [ARL] Fix conflicting function types (#2246)
Added EFIAPI modifier to fix conflicting function types with .h file

Signed-off-by: kokweich <kok.wei.chan@intel.com>
2024-08-02 11:15:09 +08:00
ongeelim 812a83f4b2
feat: [ARLS] Update IFWI ingredient list in StitchIfwiConfig.py (#2245)
Newer ARL-S silicon only has one DMU binary and one PUNIT binary
components.

Signed-off-by: Ong Ee Lim <ee.lim.ong@intel.com>
2024-08-01 07:27:40 -04:00
Randy 34a701932d feat: [RPLS] Update MR4 Release
FSP version is 0C00DE40
platform version is 1.4
Microcode Files are: ['m_07_90672_00000036.pdb', 'm_32_b0671_00000123.pdb']

Signed-off-by: Randy <randy.lin@intel.com>
2024-07-31 08:42:41 -07:00
Sindhura Grandhi 472586d1cd feat:[ARLS] Update HeciMeExt Library to accomodate all ARL SKUs
- Update Common MeChipsetLib to account for ARLS Me Bus.
  Now,the bus number comes from Platform code:
  if ARLS bus = 0x80, else bus = 0x0
- Update Heci Pci read calls in HeciMeExtLib to account for
  both ARLS and ARL U/H  BDF differences.
- Delete ARL specific MeChipset header files as it now uses
  common header files from Common Package.

Signed-off-by: Sindhura Grandhi <sindhura.grandhi@intel.com>
2024-07-31 08:39:22 -07:00
Vincent Chen d009ecffc5
[MTL] Update FSP/UCODE/VBT for MR1 release (#2241)
- FSP: IoT MTL-UH_MTL-PS MR1 (0D.E0.B8.40)
- Microcode: 1e
- VBT: 256
- platform version: 1.1

Signed-off-by: Vincent Chen <vincent.chen@intel.com>
2024-07-31 10:52:24 +08:00
kokweich 23111c87db
fix: [ARL-S] Fixed S0ix failing due to incorrect PCI ASPM and L1 config (#2225)
S0ix failed when NVME attached due to incorrect PCI device configuration
Ported RootPortDownStreamPmConfiguration and related Libraries
To fix incorrect PCIE ASPM and L1 Configuration

Implementation is silicon-dependent due to registers definition

This implementation is using the following ADL PCIE PM PATCH as reference
3bbfe44bec

Signed-off-by: kokweich <kok.wei.chan@intel.com>
2024-07-29 15:20:41 -07:00
randylintw b0b951276e
fix: [RPLP] Stitch fail when missing diag acm binary (#2238)
Cause by cefbf78dae.
The default build will include the DACM region and the replace file should be present during stitch step.

Add fusa stitch option for users who want to replace that component in the BIOS.

Signed-off-by: Randy <randy.lin@intel.com>
2024-07-29 09:43:22 +08:00
Vincent Chen fe7c3393e8
[RPLP] Update for MR2 release (#2239)
- FSP version is NEX RPL-P MR2 (0C.01.DE.40)
- Microcode version is 411d
- VBT version is 253
- platform version is 1.2

Signed-off-by: Vincent Chen <vincent.chen@intel.com>
2024-07-29 09:42:59 +08:00
Vincent Chen dc3ab7d5ab fix: [EHL] WOL is not working in PCH GbE port
modify GPIO GPP_U0 (RGMII2_INT) for PCH GbE

Signed-off-by: Vincent Chen <vincent.chen@intel.com>
2024-07-25 10:48:29 -07:00
bejeanmo 6782c945b4
feat: [RPL-PS] Upstream RPL-PS code. (#2231)
Add RPL-PS Platform code to public repo.

Signed-off-by: Bejean Mosher <bejean.mosher@intel.com>
2024-07-24 11:59:49 -07:00
Sindhura Grandhi b6734ab7b7 [ARLS] Remove project specific Me Chipset Library
- Use MeChipsetLib from the Common Soc package and remove
  Silicon specific as its redundant

Signed-off-by: Sindhura Grandhi <sindhura.grandhi@intel.com>
2024-07-23 21:38:07 -07:00
Sindhura Grandhi 93afe0f4f7 [RPLP] Increase OS loader size to resolve build failure
Signed-off-by: Sindhura Grandhi <sindhura.grandhi@intel.com>
2024-07-23 21:37:00 -07:00
Randy cefbf78dae feat: [RPLP] support loading diagnostic acm binary
Signed-off-by: Randy <randy.lin@intel.com>
2024-07-18 08:24:32 -07:00