soc/tegra: Set ERD bit to mask inband errors

Add a function to set the ERD (Error Response Disable) bit in the
MISCREG_CCROC_ERR_CONFIG register from the Control Backbone (CBB) error
handler driver.

ERD bit allows masking of SError due to inband errors which are caused
by illegal register accesses through CBB. When the bit is set, interrupt
is used for reporting errors and magic code '0xdead2003' is returned.
This change is only required for Tegra194 SoC as the config is moved to
CBB register space for future SoC's. Also, remove unmapping the
apbmisc_base as it's required to get the base address for accessing the
misc register.

Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
This commit is contained in:
Sumit Gupta 2022-05-12 01:46:43 +05:30 committed by Thierry Reding
parent 568035b01c
commit 96765cc475
2 changed files with 33 additions and 2 deletions

View File

@ -16,12 +16,16 @@
#define FUSE_SKU_INFO 0x10 #define FUSE_SKU_INFO 0x10
#define ERD_ERR_CONFIG 0x120c
#define ERD_MASK_INBAND_ERR 0x1
#define PMC_STRAPPING_OPT_A_RAM_CODE_SHIFT 4 #define PMC_STRAPPING_OPT_A_RAM_CODE_SHIFT 4
#define PMC_STRAPPING_OPT_A_RAM_CODE_MASK_LONG \ #define PMC_STRAPPING_OPT_A_RAM_CODE_MASK_LONG \
(0xf << PMC_STRAPPING_OPT_A_RAM_CODE_SHIFT) (0xf << PMC_STRAPPING_OPT_A_RAM_CODE_SHIFT)
#define PMC_STRAPPING_OPT_A_RAM_CODE_MASK_SHORT \ #define PMC_STRAPPING_OPT_A_RAM_CODE_MASK_SHORT \
(0x3 << PMC_STRAPPING_OPT_A_RAM_CODE_SHIFT) (0x3 << PMC_STRAPPING_OPT_A_RAM_CODE_SHIFT)
static void __iomem *apbmisc_base;
static bool long_ram_code; static bool long_ram_code;
static u32 strapping; static u32 strapping;
static u32 chipid; static u32 chipid;
@ -93,6 +97,28 @@ u32 tegra_read_ram_code(void)
} }
EXPORT_SYMBOL_GPL(tegra_read_ram_code); EXPORT_SYMBOL_GPL(tegra_read_ram_code);
/*
* The function sets ERD(Error Response Disable) bit.
* This allows to mask inband errors and always send an
* OKAY response from CBB to the master which caused error.
*/
int tegra194_miscreg_mask_serror(void)
{
if (!apbmisc_base)
return -EPROBE_DEFER;
if (!of_machine_is_compatible("nvidia,tegra194")) {
WARN(1, "Only supported for Tegra194 devices!\n");
return -EOPNOTSUPP;
}
writel_relaxed(ERD_MASK_INBAND_ERR,
apbmisc_base + ERD_ERR_CONFIG);
return 0;
}
EXPORT_SYMBOL(tegra194_miscreg_mask_serror);
static const struct of_device_id apbmisc_match[] __initconst = { static const struct of_device_id apbmisc_match[] __initconst = {
{ .compatible = "nvidia,tegra20-apbmisc", }, { .compatible = "nvidia,tegra20-apbmisc", },
{ .compatible = "nvidia,tegra186-misc", }, { .compatible = "nvidia,tegra186-misc", },
@ -134,7 +160,7 @@ void __init tegra_init_revision(void)
void __init tegra_init_apbmisc(void) void __init tegra_init_apbmisc(void)
{ {
void __iomem *apbmisc_base, *strapping_base; void __iomem *strapping_base;
struct resource apbmisc, straps; struct resource apbmisc, straps;
struct device_node *np; struct device_node *np;
@ -196,7 +222,6 @@ void __init tegra_init_apbmisc(void)
pr_err("failed to map APBMISC registers\n"); pr_err("failed to map APBMISC registers\n");
} else { } else {
chipid = readl_relaxed(apbmisc_base + 4); chipid = readl_relaxed(apbmisc_base + 4);
iounmap(apbmisc_base);
} }
strapping_base = ioremap(straps.start, resource_size(&straps)); strapping_base = ioremap(straps.start, resource_size(&straps));

View File

@ -58,6 +58,7 @@ u32 tegra_read_chipid(void);
u8 tegra_get_chip_id(void); u8 tegra_get_chip_id(void);
u8 tegra_get_platform(void); u8 tegra_get_platform(void);
bool tegra_is_silicon(void); bool tegra_is_silicon(void);
int tegra194_miscreg_mask_serror(void);
#else #else
static struct tegra_sku_info tegra_sku_info __maybe_unused; static struct tegra_sku_info tegra_sku_info __maybe_unused;
@ -95,6 +96,11 @@ static inline bool tegra_is_silicon(void)
{ {
return false; return false;
} }
static inline int tegra194_miscreg_mask_serror(void)
{
return false;
}
#endif #endif
struct device *tegra_soc_device_register(void); struct device *tegra_soc_device_register(void);