OrgZephyr/zephyr
OrgZephyr
/
zephyr
mirror of https://github.com/zephyrproject-rtos/zephyr.git
1
0
Fork 0
Code Issues Releases Wiki Activity
zephyr/share/sysbuild
History
Marc Herbert 811a74c019 boards/Kconfig: $BOARD_REVISION -> $(BOARD_REVISION) 
Add parentheses missing around $BOARD_REVISION.

The syntax without parentheses has been deprecated for at least 5 years:
https://github.com/ulfalizer/Kconfiglib/commit/374f48873424f9

That same documentation states "Using the old syntax with an undefined
environment variable keeps the string as is." This what actually happens
on Windows where `build/zephyr/.config` looks like this:

  CONFIG_BOARD_REVISION="$BOARD_REVISION"

I found this because the behavior differs on Linux where the same,
"old" syntax produces this instead:

  CONFIG_BOARD_REVISION=""

This could be because environment variables work differently?
(BOARD_REVISION is passed from kconfig.cmake to kconfiglib.py thanks to
cmake -E env)

Let's not try to debug this and just drop the deprecated syntax. It
aligns both Windows and Linux on the same, expected, empty string
behavior.

Note these are the only two `def_string` found across all Kconfig files
right now.

Fixes commit c11b7852d1 ("Kconfig: add CONFIG_BOARD_REVISION")
Fixes commit e2ff2a88ba ("sysbuild: include HWMv2 Kconfig in sysbuild")

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
 		2024-03-13 08:38:07 +01:00
..
cmake hwmv2: Introduce Hardware model version 2 and convert devices 2024-03-02 16:56:33 -05:00
image_configurations sysbuild: bootloader: Fix setting application Kconfig in MCUboot 2023-11-22 17:32:33 +01:00
images
…
CMakeLists.txt sysbuild: include HWMv2 Kconfig in sysbuild 2024-03-04 15:27:09 +00:00
Kconfig sysbuild: include HWMv2 Kconfig in sysbuild 2024-03-04 15:27:09 +00:00
Kconfig.v1 sysbuild: include HWMv2 Kconfig in sysbuild 2024-03-04 15:27:09 +00:00
Kconfig.v2 boards/Kconfig: $BOARD_REVISION -> $(BOARD_REVISION) 2024-03-13 08:38:07 +01:00