417a9e81ec
This commit makes the device tree configuration decide which link layer is compiled in. We do this to avoid hard-to-understand linker errors referencing device tree nodes. The following configuration creates a difficult to parse linker error: * BT_LL_CHOICE contains multiple entries, BT_LL_SW_SPLIT is selected. * Each BT_LL_CHOICE has its own unique device tree node with its own "compatible". * Only one of the link layer device tree nodes has status "okay", but not the one corresponding to BT_LL_SW_SPLIT. The linker error indicates that code using the HCI driver fails to link with the controller. This because the HCI driver device tree node references the link layer selected in devicetree which is not compiled in. By adding a dependendency to the device tree node, this can no longer happen. Instead, if BT_LL_SW_SPLIT is now selected in a configuration file, a Kconfig warning will be issued: ``` warning: The choice symbol BT_LL_SW_SPLIT (defined at subsys/bluetooth/controller/Kconfig:129) was selected (set =y), but BT_LL_SOFTDEVICE (defined at /home/ruge/ncs/nrf/subsys/bluetooth/controller/Kconfig:11) ended up as the choice selection. ``` This should be easier to understand than: ``` ...(hci_core.c.obj):(.data.bt_dev+0x16c): undefined reference to `__device_dts_ord_132' ``` After this commit we should consider getting rid of link layer selection from Kconfig completely as the link layer is in practice selected through device tree. Unit tests have been updated to satisfy the dts dependency. Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no> |
||
|---|---|---|
| .. | ||
| coex | ||
| crypto | ||
| flash | ||
| hal | ||
| hci | ||
| include | ||
| ll_sw | ||
| ticker | ||
| util | ||
| CMakeLists.txt | ||
| Kconfig | ||
| Kconfig.df | ||
| Kconfig.dtm | ||
| Kconfig.ll_sw_split | ||