Commit Graph

6 Commits

Author SHA1 Message Date
Ulf Magnusson 16ca6a76da intel_s1000_crb: messenger.py: Simplify loops to fix pylint warnings
Simplify two loops in create_memread_cmd() by looping over elements
instead of indices, to fix two pylint warnings.

Fixing warnings for a CI check.

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
2019-09-07 08:13:41 -04:00
Ulf Magnusson 4d207895b4 intel_s1000_crb: scripts: Remove '== False/True' tests
Fix pylint warnings like these:

    Comparison to True should be just 'expr' (singleton-comparison)
    Comparison to False should be 'not expr' (singleton-comparison)

I checked that GPIO.read() only returns True/False in the
python-periphery docs.

Getting rid of pylint warnings for a CI check.

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
2019-09-07 08:07:57 -04:00
Ulf Magnusson e3ff959d30 intel_s1000_crb: messenger.py: Make endian_swap() static
Doesn't use 'self'. Fixes this pylint warning:

    boards/xtensa/intel_s1000_crb/support/messenger.py:50:4: R0201:
    Method could be a function (no-self-use)

If this function is meant to be internal to messenger.py, then a better
option than @staticmethod might be to turn it into a regular function.

Fixing pylint warnings for a CI check.

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
2019-09-07 08:04:15 -04:00
Ulf Magnusson 0d39a10fbb scripts: Fix random typo'd whitespace
Reported by pylint's 'bad-whitespace' warning.

Not gonna enable this warning in the CI check, because it flags stuff
like deliberately aligning assignments and gets too cultish. Just a
cleanup pass.

For whatever reason, the common convention in Python is to skip spaces
around '=' when passing keyword arguments and giving default arguments:

    f(x=3, y=4)
    def f(x, y=8):
        ...

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
2019-09-07 07:54:17 -04:00
Anas Nashif f2cb20c772 docs: fix misspelling across the tree
Found a few annoying typos and figured I better run script and
fix anything it can find, here are the results...

Signed-off-by: Anas Nashif <anas.nashif@intel.com>
2019-06-19 15:34:13 -05:00
Sathish Kuttan 8075de7b94 boards: intel_s1000_crb: Image download scripts
Python scripts to download a zephyr binary image (zephyr.bin) to
Intel S1000 from a linux host.
The linux host's SPI master and GPIOs shall be connected to the
corresponding SPI slave and I/Os respectively.

Signed-off-by: Sathish Kuttan <sathish.k.kuttan@intel.com>
2019-05-29 22:44:35 -04:00