OrgZephyr/zephyr
OrgZephyr
/
zephyr
mirror of https://github.com/zephyrproject-rtos/zephyr.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Bluetooth: TBS: Fix issues with lookup_inst_by_uri_scheme 

The function took the uri as a `char *` but is in fact
not a null terminated string so change the type to uint8_t *.

Add a check fro uri_len == 0 before doing uri_len - 1

Changed the found check to just check the first octet rather
than the more costly strlen.

Fixed the type of the iterator

Add a break in the loop as we only need to find one ":"

Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
This commit is contained in:
Emil Gydesen 2024-08-19 15:23:49 +02:00 committed by Mahesh Mahadevan
parent 52cb8c07d1
commit 8f76cdd891
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
subsys/bluetooth/audio/tbs.c
View File

@ -262,19 +262,23 @@ static bool uri_scheme_in_list(const char *uri_scheme,
return false;
}
static struct tbs_service_inst *lookup_inst_by_uri_scheme(const char *uri,
uint8_t uri_len)
static struct tbs_service_inst *lookup_inst_by_uri_scheme(const uint8_t *uri, uint8_t uri_len)
{
char uri_scheme[CONFIG_BT_TBS_MAX_URI_LENGTH] = { 0 };
if (uri_len == 0) {
return NULL;
}
/* Look for ':' between the first and last char */
for (int i = 1; i < uri_len - 1; i++) {
for (uint8_t i = 1U; i < uri_len - 1U; i++) {
if (uri[i] == ':') {
(void)memcpy(uri_scheme, uri, i);
break;
}
}
if (strlen(uri_scheme) == 0) {
if (uri_scheme[0] == '\0') {
/* No URI scheme found */
return NULL;
}