OrgZephyr/zephyr
OrgZephyr
/
zephyr
mirror of https://github.com/zephyrproject-rtos/zephyr.git
1
0
Fork 0
Code Issues Releases Wiki Activity

shell: modules: do not use k_thread_foreach with shell callbacks 

Always use k_thread_foreach_unlocked with callbacks which print
something out to the shell, as they might call arch_irq_unlock.
Fixes #66660.

Signed-off-by: Benedikt Schmidt <benedikt.schmidt@embedded-solutions.at>
This commit is contained in:
Benedikt Schmidt 2023-12-19 16:42:34 +01:00 committed by Fabio Baltieri
parent ed5352ffce
commit 4c731f27c6
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
subsys/shell/modules/kernel_service.c
View File

@ -197,11 +197,12 @@ static int cmd_kernel_threads(const struct shell *sh,
shell_print(sh, "Scheduler: %u since last call", sys_clock_elapsed());
shell_print(sh, "Threads:");
#ifdef CONFIG_SMP
/*
* Use the unlocked version as the callback itself might call
* arch_irq_unlock.
*/
k_thread_foreach_unlocked(shell_tdata_dump, (void *)sh);
#else
k_thread_foreach(shell_tdata_dump, (void *)sh);
#endif
return 0;
}
@ -245,11 +246,11 @@ static int cmd_kernel_stacks(const struct shell *sh,
memset(pad, ' ', MAX((THREAD_MAX_NAM_LEN - strlen("IRQ 00")), 1));
#ifdef CONFIG_SMP
/*
* Use the unlocked version as the callback itself might call
* arch_irq_unlock.
*/
k_thread_foreach_unlocked(shell_stack_dump, (void *)sh);
#else
k_thread_foreach(shell_stack_dump, (void *)sh);
#endif
/* Placeholder logic for interrupt stack until we have better
* kernel support, including dumping arch-specific exception-related