OrgZephyr/zephyr
OrgZephyr
/
zephyr
mirror of https://github.com/zephyrproject-rtos/zephyr.git
1
0
Fork 0
Code Issues Releases Wiki Activity

sensor: max17055: add missing return value check 

This commit adds a missing return value check during register read.
Added an imidiate return to remove the seemingly unwanted side
effect of also waiting for the bus read to work.

Fixes #65374

Signed-off-by: Benjamin Björnsson <benjamin.bjornsson@gmail.com>
This commit is contained in:
Benjamin Björnsson 2023-11-17 20:37:00 +01:00 committed by Henrik Brix Andersen
parent 9781d13f19
commit 0cec0dc749
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/sensor/max17055/max17055.c
View File

@ -348,6 +348,7 @@ static int max17055_write_config(const struct device *dev)
uint16_t d_pacc = d_qacc * 44138 / design_capacity;
uint16_t i_chg_term = current_ma_to_max17055(config->rsense_mohms, config->i_chg_term);
uint16_t v_empty;
int ret;
LOG_DBG("Writing configuration parameters");
LOG_DBG("DesignCap: %u, dQAcc: %u, IChgTerm: %u, dPAcc: %u",
@ -386,7 +387,10 @@ static int max17055_write_config(const struct device *dev)
uint16_t model_cfg = MODELCFG_REFRESH;
while (model_cfg & MODELCFG_REFRESH) {
max17055_reg_read(dev, MODEL_CFG, &model_cfg);
ret = max17055_reg_read(dev, MODEL_CFG, &model_cfg);
if (ret) {
return ret;
}
k_sleep(K_MSEC(10));
}