OrgZephyr/zephyr
OrgZephyr
/
zephyr
mirror of https://github.com/zephyrproject-rtos/zephyr.git
1
0
Fork 0
Code Issues Releases Wiki Activity

input: paw32xx: only reschedule the handler if motion is asserted 

The motion event handler is currently setup to always retrigger until
there's no more motion data from the sensor. Change that to only
retrigger if the motion pin is asserted when the handler has finished
running, this saves a bunch of unnecessary spi transactions.

Ideally this driver would use a level interrupt, but I'd rather avoid
that as that is unsupported by many gpio controllers.

Signed-off-by: Fabio Baltieri <fabiobaltieri@google.com>
This commit is contained in:
Fabio Baltieri 2024-07-13 17:32:58 +01:00 committed by Anas Nashif
parent d0808473f2
commit 03f1dd413d
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/input/input_paw32xx.c
View File

@ -221,8 +221,10 @@ static void paw32xx_motion_work_handler(struct k_work *work)
input_report_rel(data->dev, cfg->axis_x, x, false, K_FOREVER);
input_report_rel(data->dev, cfg->axis_y, y, true, K_FOREVER);
/* Trigger one more scan in case more data is available. */
k_work_submit(&data->motion_work);
/* Trigger one more scan if more data is available. */
if (gpio_pin_get_dt(&cfg->motion_gpio)) {
k_work_submit(&data->motion_work);
}
}
static void paw32xx_motion_handler(const struct device *gpio_dev,