zephyr/scripts/coccinelle/unsigned_shift.cocci

/// Use BIT() helper macro instead of hardcoding using bitshifting
///
// Confidence: High
// Copyright (c) 2017 Intel Corporation
//
// SPDX-License-Identifier: Apache-2.0

virtual patch

@depends on patch && !(file in "ext")@
expression A;
@@

- (1 << A)
+ BIT(A)
coccinelle: unsigned_shift.cocci: Update script * Use `expression` metavariable instead of `constant` to catch missing cases such as: diff -u -p a/subsys/net/ip/rpl.c b/subsys/net/ip/rpl.c --- a/subsys/net/ip/rpl.c +++ b/subsys/net/ip/rpl.c @@ -686,7 +686,7 @@ static void new_dio_interval(struct net_ { u32_t time; - time = 1 << instance->dio_interval_current; + time = BIT(instance->dio_interval_current); * Provide a single liner description at top using `///` comments. This one liner is displayed when using `--verbose` mode of coccicheck. * Specify Condidence level property adhering to coccinelle.rst section "Proposing new semantic patches". * Add virtual patch rule to handle the patch case when coccicheck is supplied with `--mode=patch` option. * Edit patch rule to remove redundant parentheses in the output. * Add `depends on !(file in "ext")` to ignore reports from `ext/` directory. Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com> 2018-11-05 22:46:49 +08:00			`/// Use BIT() helper macro instead of hardcoding using bitshifting`
			`///`
			`// Confidence: High`
kernel: Fix bitwise operators with unsigned operators Bitwise operators should be used only with unsigned integer operands because the result os bitwise operations on signed integers are implementation-defined. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com> 2018-08-16 02:52:00 +08:00			`// Copyright (c) 2017 Intel Corporation`
			`//`
			`// SPDX-License-Identifier: Apache-2.0`

coccinelle: unsigned_shift.cocci: Update script * Use `expression` metavariable instead of `constant` to catch missing cases such as: diff -u -p a/subsys/net/ip/rpl.c b/subsys/net/ip/rpl.c --- a/subsys/net/ip/rpl.c +++ b/subsys/net/ip/rpl.c @@ -686,7 +686,7 @@ static void new_dio_interval(struct net_ { u32_t time; - time = 1 << instance->dio_interval_current; + time = BIT(instance->dio_interval_current); * Provide a single liner description at top using `///` comments. This one liner is displayed when using `--verbose` mode of coccicheck. * Specify Condidence level property adhering to coccinelle.rst section "Proposing new semantic patches". * Add virtual patch rule to handle the patch case when coccicheck is supplied with `--mode=patch` option. * Edit patch rule to remove redundant parentheses in the output. * Add `depends on !(file in "ext")` to ignore reports from `ext/` directory. Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com> 2018-11-05 22:46:49 +08:00			`virtual patch`

			`@depends on patch && !(file in "ext")@`
			`expression A;`
kernel: Fix bitwise operators with unsigned operators Bitwise operators should be used only with unsigned integer operands because the result os bitwise operations on signed integers are implementation-defined. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com> 2018-08-16 02:52:00 +08:00			`@@`

coccinelle: unsigned_shift.cocci: Update script * Use `expression` metavariable instead of `constant` to catch missing cases such as: diff -u -p a/subsys/net/ip/rpl.c b/subsys/net/ip/rpl.c --- a/subsys/net/ip/rpl.c +++ b/subsys/net/ip/rpl.c @@ -686,7 +686,7 @@ static void new_dio_interval(struct net_ { u32_t time; - time = 1 << instance->dio_interval_current; + time = BIT(instance->dio_interval_current); * Provide a single liner description at top using `///` comments. This one liner is displayed when using `--verbose` mode of coccicheck. * Specify Condidence level property adhering to coccinelle.rst section "Proposing new semantic patches". * Add virtual patch rule to handle the patch case when coccicheck is supplied with `--mode=patch` option. * Edit patch rule to remove redundant parentheses in the output. * Add `depends on !(file in "ext")` to ignore reports from `ext/` directory. Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com> 2018-11-05 22:46:49 +08:00			`- (1 << A)`
			`+ BIT(A)`