OrgZephyr/zephyr
OrgZephyr
/
zephyr
mirror of https://github.com/zephyrproject-rtos/zephyr.git
1
0
Fork 0
Code Issues Releases Wiki Activity
zephyr/drivers/dma/dma_handlers.c

26 lines
581 B
C
Raw Normal View History

dma: add system calls for dma_start/dma_stop As per current policy of requiring supervisor mode to register callbacks, dma_config() is omitted. A note added about checking the channel ID for start/stop, current implementations already do this but best make it explicitly documented. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-02-10 05:58:37 +08:00
/*
* Copyright (c) 2018 Intel Corporation
*
* SPDX-License-Identifier: Apache-2.0
*/
#include <dma.h>
#include <syscall_handler.h>
/* Both of these APIs are assuming that the drive implementations are checking
* the validity of the channel ID and returning -errno if it's bogus
*/
syscalls: remove policy from handler checks The various macros to do checks in system call handlers all implictly would generate a kernel oops if a check failed. This is undesirable for a few reasons: * System call handlers that acquire resources in the handler have no good recourse for cleanup if a check fails. * In some cases we may want to propagate a return value back to the caller instead of just killing the calling thread, even though the base API doesn't do these checks. These macros now all return a value, if nonzero is returned the check failed. K_OOPS() now wraps these calls to generate a kernel oops. At the moment, the policy for all APIs has not changed. They still all oops upon a failed check/ The macros now use the Z_ notation for private APIs. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-05-05 06:57:57 +08:00
Z_SYSCALL_HANDLER(dma_start, dev, channel)
dma: add system calls for dma_start/dma_stop As per current policy of requiring supervisor mode to register callbacks, dma_config() is omitted. A note added about checking the channel ID for start/stop, current implementations already do this but best make it explicitly documented. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-02-10 05:58:37 +08:00
{
syscalls: remove policy from handler checks The various macros to do checks in system call handlers all implictly would generate a kernel oops if a check failed. This is undesirable for a few reasons: * System call handlers that acquire resources in the handler have no good recourse for cleanup if a check fails. * In some cases we may want to propagate a return value back to the caller instead of just killing the calling thread, even though the base API doesn't do these checks. These macros now all return a value, if nonzero is returned the check failed. K_OOPS() now wraps these calls to generate a kernel oops. At the moment, the policy for all APIs has not changed. They still all oops upon a failed check/ The macros now use the Z_ notation for private APIs. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-05-05 06:57:57 +08:00
Z_OOPS(Z_SYSCALL_DRIVER_DMA(dev, start));
dma: add system calls for dma_start/dma_stop As per current policy of requiring supervisor mode to register callbacks, dma_config() is omitted. A note added about checking the channel ID for start/stop, current implementations already do this but best make it explicitly documented. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-02-10 05:58:37 +08:00
return _impl_dma_start((struct device *)dev, channel);
}
syscalls: remove policy from handler checks The various macros to do checks in system call handlers all implictly would generate a kernel oops if a check failed. This is undesirable for a few reasons: * System call handlers that acquire resources in the handler have no good recourse for cleanup if a check fails. * In some cases we may want to propagate a return value back to the caller instead of just killing the calling thread, even though the base API doesn't do these checks. These macros now all return a value, if nonzero is returned the check failed. K_OOPS() now wraps these calls to generate a kernel oops. At the moment, the policy for all APIs has not changed. They still all oops upon a failed check/ The macros now use the Z_ notation for private APIs. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-05-05 06:57:57 +08:00
Z_SYSCALL_HANDLER(dma_stop, dev, channel)
dma: add system calls for dma_start/dma_stop As per current policy of requiring supervisor mode to register callbacks, dma_config() is omitted. A note added about checking the channel ID for start/stop, current implementations already do this but best make it explicitly documented. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-02-10 05:58:37 +08:00
{
syscalls: remove policy from handler checks The various macros to do checks in system call handlers all implictly would generate a kernel oops if a check failed. This is undesirable for a few reasons: * System call handlers that acquire resources in the handler have no good recourse for cleanup if a check fails. * In some cases we may want to propagate a return value back to the caller instead of just killing the calling thread, even though the base API doesn't do these checks. These macros now all return a value, if nonzero is returned the check failed. K_OOPS() now wraps these calls to generate a kernel oops. At the moment, the policy for all APIs has not changed. They still all oops upon a failed check/ The macros now use the Z_ notation for private APIs. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-05-05 06:57:57 +08:00
Z_OOPS(Z_SYSCALL_DRIVER_DMA(dev, stop));
dma: add system calls for dma_start/dma_stop As per current policy of requiring supervisor mode to register callbacks, dma_config() is omitted. A note added about checking the channel ID for start/stop, current implementations already do this but best make it explicitly documented. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-02-10 05:58:37 +08:00
return _impl_dma_stop((struct device *)dev, channel);
}