OrgZephyr/zephyr
OrgZephyr
/
zephyr
mirror of https://github.com/zephyrproject-rtos/zephyr.git
1
0
Fork 0
Code Issues Releases Wiki Activity
zephyr/drivers/dma/dma_handlers.c

27 lines
747 B
C
Raw Normal View History

dma: add system calls for dma_start/dma_stop As per current policy of requiring supervisor mode to register callbacks, dma_config() is omitted. A note added about checking the channel ID for start/stop, current implementations already do this but best make it explicitly documented. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-02-10 05:58:37 +08:00
/*
* Copyright (c) 2018 Intel Corporation
*
* SPDX-License-Identifier: Apache-2.0
*/
cleanup: include/: move dma.h to drivers/dma.h move dma.h to drivers/dma.h and create a shim for backward-compatibility. No functional changes to the headers. A warning in the shim can be controlled with CONFIG_COMPAT_INCLUDES. Related to #16539 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
2019-06-26 03:53:48 +08:00
#include <drivers/dma.h>
dma: add system calls for dma_start/dma_stop As per current policy of requiring supervisor mode to register callbacks, dma_config() is omitted. A note added about checking the channel ID for start/stop, current implementations already do this but best make it explicitly documented. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-02-10 05:58:37 +08:00
#include <syscall_handler.h>
/* Both of these APIs are assuming that the drive implementations are checking
* the validity of the channel ID and returning -errno if it's bogus
*/
device: Const-ify all device driver instance pointers Now that device_api attribute is unmodified at runtime, as well as all the other attributes, it is possible to switch all device driver instance to be constant. A coccinelle rule is used for this: @r_const_dev_1 disable optional_qualifier @ @@ -struct device * +const struct device * @r_const_dev_2 disable optional_qualifier @ @@ -struct device * const +const struct device * Fixes #27399 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
2020-05-01 02:33:38 +08:00
static inline int z_vrfy_dma_start(const struct device *dev, uint32_t channel)
dma: add system calls for dma_start/dma_stop As per current policy of requiring supervisor mode to register callbacks, dma_config() is omitted. A note added about checking the channel ID for start/stop, current implementations already do this but best make it explicitly documented. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-02-10 05:58:37 +08:00
{
syscalls: remove policy from handler checks The various macros to do checks in system call handlers all implictly would generate a kernel oops if a check failed. This is undesirable for a few reasons: * System call handlers that acquire resources in the handler have no good recourse for cleanup if a check fails. * In some cases we may want to propagate a return value back to the caller instead of just killing the calling thread, even though the base API doesn't do these checks. These macros now all return a value, if nonzero is returned the check failed. K_OOPS() now wraps these calls to generate a kernel oops. At the moment, the policy for all APIs has not changed. They still all oops upon a failed check/ The macros now use the Z_ notation for private APIs. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-05-05 06:57:57 +08:00
Z_OOPS(Z_SYSCALL_DRIVER_DMA(dev, start));
device: Const-ify all device driver instance pointers Now that device_api attribute is unmodified at runtime, as well as all the other attributes, it is possible to switch all device driver instance to be constant. A coccinelle rule is used for this: @r_const_dev_1 disable optional_qualifier @ @@ -struct device * +const struct device * @r_const_dev_2 disable optional_qualifier @ @@ -struct device * const +const struct device * Fixes #27399 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
2020-05-01 02:33:38 +08:00
return z_impl_dma_start((const struct device *)dev, channel);
dma: add system calls for dma_start/dma_stop As per current policy of requiring supervisor mode to register callbacks, dma_config() is omitted. A note added about checking the channel ID for start/stop, current implementations already do this but best make it explicitly documented. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-02-10 05:58:37 +08:00
}
kernel: Port remaining syscalls to new API These calls are not accessible in CI test, nor do they get built on common platforms (in at least one case I found a typo which proved the code was truly unused). These changes are blind, so live in a separate commit. But the nature of the port is mechanical, all other syscalls in the system work fine, and any errors should be easily corrected. Signed-off-by: Andy Ross <andrew.j.ross@intel.com>
2019-08-14 02:34:34 +08:00
#include <syscalls/dma_start_mrsh.c>
dma: add system calls for dma_start/dma_stop As per current policy of requiring supervisor mode to register callbacks, dma_config() is omitted. A note added about checking the channel ID for start/stop, current implementations already do this but best make it explicitly documented. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-02-10 05:58:37 +08:00
device: Const-ify all device driver instance pointers Now that device_api attribute is unmodified at runtime, as well as all the other attributes, it is possible to switch all device driver instance to be constant. A coccinelle rule is used for this: @r_const_dev_1 disable optional_qualifier @ @@ -struct device * +const struct device * @r_const_dev_2 disable optional_qualifier @ @@ -struct device * const +const struct device * Fixes #27399 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
2020-05-01 02:33:38 +08:00
static inline int z_vrfy_dma_stop(const struct device *dev, uint32_t channel)
dma: add system calls for dma_start/dma_stop As per current policy of requiring supervisor mode to register callbacks, dma_config() is omitted. A note added about checking the channel ID for start/stop, current implementations already do this but best make it explicitly documented. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-02-10 05:58:37 +08:00
{
syscalls: remove policy from handler checks The various macros to do checks in system call handlers all implictly would generate a kernel oops if a check failed. This is undesirable for a few reasons: * System call handlers that acquire resources in the handler have no good recourse for cleanup if a check fails. * In some cases we may want to propagate a return value back to the caller instead of just killing the calling thread, even though the base API doesn't do these checks. These macros now all return a value, if nonzero is returned the check failed. K_OOPS() now wraps these calls to generate a kernel oops. At the moment, the policy for all APIs has not changed. They still all oops upon a failed check/ The macros now use the Z_ notation for private APIs. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-05-05 06:57:57 +08:00
Z_OOPS(Z_SYSCALL_DRIVER_DMA(dev, stop));
device: Const-ify all device driver instance pointers Now that device_api attribute is unmodified at runtime, as well as all the other attributes, it is possible to switch all device driver instance to be constant. A coccinelle rule is used for this: @r_const_dev_1 disable optional_qualifier @ @@ -struct device * +const struct device * @r_const_dev_2 disable optional_qualifier @ @@ -struct device * const +const struct device * Fixes #27399 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
2020-05-01 02:33:38 +08:00
return z_impl_dma_stop((const struct device *)dev, channel);
dma: add system calls for dma_start/dma_stop As per current policy of requiring supervisor mode to register callbacks, dma_config() is omitted. A note added about checking the channel ID for start/stop, current implementations already do this but best make it explicitly documented. Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
2018-02-10 05:58:37 +08:00
}
kernel: Port remaining syscalls to new API These calls are not accessible in CI test, nor do they get built on common platforms (in at least one case I found a typo which proved the code was truly unused). These changes are blind, so live in a separate commit. But the nature of the port is mechanical, all other syscalls in the system work fine, and any errors should be easily corrected. Signed-off-by: Andy Ross <andrew.j.ross@intel.com>
2019-08-14 02:34:34 +08:00
#include <syscalls/dma_stop_mrsh.c>