OrgZephyr/zephyr
OrgZephyr
/
zephyr
mirror of https://github.com/zephyrproject-rtos/zephyr.git
1
0
Fork 0
Code Issues Releases Wiki Activity
zephyr/scripts/coccinelle/irq_lock.cocci

46 lines
566 B
Plaintext
Raw Normal View History

coccinelle: irq_lock.cocci: Update script * Provide a single liner description at top using `///` comments. This one liner is displayed when using `--verbose` mode of coccicheck. * Specify Condidence level property adhering to coccinelle.rst section "Proposing new semantic patches". * Add virtual patch rule to handle the patch case when coccicheck is supplied with `--mode=patch` option. * Add `depends on !(file in "ext")` to ignore reports from `ext/` directory. * Simplify rule to use disjunctions and use "exists" to match any available control path. Suggested-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
2018-11-06 01:57:43 +08:00
/// Use unsigned int as the return value for irq_lock()
///
// Confidence: High
irq: Fix irq_lock api usage irq_lock returns an unsigned int, though, several places was using signed int. This commit fix this behaviour. In order to avoid this error happens again, a coccinelle script was added and can be used to check violations. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
2018-08-15 08:57:08 +08:00
// Copyright (c) 2017 Intel Corporation
//
// SPDX-License-Identifier: Apache-2.0
coccinelle: irq_lock.cocci: Update script * Provide a single liner description at top using `///` comments. This one liner is displayed when using `--verbose` mode of coccicheck. * Specify Condidence level property adhering to coccinelle.rst section "Proposing new semantic patches". * Add virtual patch rule to handle the patch case when coccicheck is supplied with `--mode=patch` option. * Add `depends on !(file in "ext")` to ignore reports from `ext/` directory. * Simplify rule to use disjunctions and use "exists" to match any available control path. Suggested-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
2018-11-06 01:57:43 +08:00
virtual patch
@find depends on !(file in "ext")@
irq: Fix irq_lock api usage irq_lock returns an unsigned int, though, several places was using signed int. This commit fix this behaviour. In order to avoid this error happens again, a coccinelle script was added and can be used to check violations. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
2018-08-15 08:57:08 +08:00
type T;
identifier i;
zephyr: replace zephyr integer types with C99 types git grep -l 'u\(8\|16\|32\|64\)_t' | \ xargs sed -i "s/u\(8\|16\|32\|64\)_t/uint\1_t/g" git grep -l 's\(8\|16\|32\|64\)_t' | \ xargs sed -i "s/s\(8\|16\|32\|64\)_t/int\1_t/g" Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
2020-05-28 00:26:57 +08:00
typedef uint32_t,uint32_t;
irq: Fix irq_lock api usage irq_lock returns an unsigned int, though, several places was using signed int. This commit fix this behaviour. In order to avoid this error happens again, a coccinelle script was added and can be used to check violations. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
2018-08-15 08:57:08 +08:00
@@
coccinelle: irq_lock.cocci: Update script * Provide a single liner description at top using `///` comments. This one liner is displayed when using `--verbose` mode of coccicheck. * Specify Condidence level property adhering to coccinelle.rst section "Proposing new semantic patches". * Add virtual patch rule to handle the patch case when coccicheck is supplied with `--mode=patch` option. * Add `depends on !(file in "ext")` to ignore reports from `ext/` directory. * Simplify rule to use disjunctions and use "exists" to match any available control path. Suggested-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
2018-11-06 01:57:43 +08:00
(
uint32_t i = irq_lock();
|
unsigned int i = irq_lock();
|
zephyr: replace zephyr integer types with C99 types git grep -l 'u\(8\|16\|32\|64\)_t' | \ xargs sed -i "s/u\(8\|16\|32\|64\)_t/uint\1_t/g" git grep -l 's\(8\|16\|32\|64\)_t' | \ xargs sed -i "s/s\(8\|16\|32\|64\)_t/int\1_t/g" Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
2020-05-28 00:26:57 +08:00
uint32_t i = irq_lock();
coccinelle: irq_lock.cocci: Update script * Provide a single liner description at top using `///` comments. This one liner is displayed when using `--verbose` mode of coccicheck. * Specify Condidence level property adhering to coccinelle.rst section "Proposing new semantic patches". * Add virtual patch rule to handle the patch case when coccicheck is supplied with `--mode=patch` option. * Add `depends on !(file in "ext")` to ignore reports from `ext/` directory. * Simplify rule to use disjunctions and use "exists" to match any available control path. Suggested-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
2018-11-06 01:57:43 +08:00
|
- T
irq: Fix irq_lock api usage irq_lock returns an unsigned int, though, several places was using signed int. This commit fix this behaviour. In order to avoid this error happens again, a coccinelle script was added and can be used to check violations. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
2018-08-15 08:57:08 +08:00
+ unsigned int
coccinelle: irq_lock.cocci: Update script * Provide a single liner description at top using `///` comments. This one liner is displayed when using `--verbose` mode of coccicheck. * Specify Condidence level property adhering to coccinelle.rst section "Proposing new semantic patches". * Add virtual patch rule to handle the patch case when coccicheck is supplied with `--mode=patch` option. * Add `depends on !(file in "ext")` to ignore reports from `ext/` directory. * Simplify rule to use disjunctions and use "exists" to match any available control path. Suggested-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
2018-11-06 01:57:43 +08:00
i = irq_lock();
)
irq: Fix irq_lock api usage irq_lock returns an unsigned int, though, several places was using signed int. This commit fix this behaviour. In order to avoid this error happens again, a coccinelle script was added and can be used to check violations. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
2018-08-15 08:57:08 +08:00
coccinelle: irq_lock.cocci: Update script * Provide a single liner description at top using `///` comments. This one liner is displayed when using `--verbose` mode of coccicheck. * Specify Condidence level property adhering to coccinelle.rst section "Proposing new semantic patches". * Add virtual patch rule to handle the patch case when coccicheck is supplied with `--mode=patch` option. * Add `depends on !(file in "ext")` to ignore reports from `ext/` directory. * Simplify rule to use disjunctions and use "exists" to match any available control path. Suggested-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
2018-11-06 01:57:43 +08:00
@find2 depends on !(file in "ext") exists@
irq: Fix irq_lock api usage irq_lock returns an unsigned int, though, several places was using signed int. This commit fix this behaviour. In order to avoid this error happens again, a coccinelle script was added and can be used to check violations. Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
2018-08-15 08:57:08 +08:00
type T;
identifier i;
@@
coccinelle: irq_lock.cocci: Update script * Provide a single liner description at top using `///` comments. This one liner is displayed when using `--verbose` mode of coccicheck. * Specify Condidence level property adhering to coccinelle.rst section "Proposing new semantic patches". * Add virtual patch rule to handle the patch case when coccicheck is supplied with `--mode=patch` option. * Add `depends on !(file in "ext")` to ignore reports from `ext/` directory. * Simplify rule to use disjunctions and use "exists" to match any available control path. Suggested-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
2018-11-06 01:57:43 +08:00
(
uint32_t i;
|
unsigned int i;
|
zephyr: replace zephyr integer types with C99 types git grep -l 'u\(8\|16\|32\|64\)_t' | \ xargs sed -i "s/u\(8\|16\|32\|64\)_t/uint\1_t/g" git grep -l 's\(8\|16\|32\|64\)_t' | \ xargs sed -i "s/s\(8\|16\|32\|64\)_t/int\1_t/g" Signed-off-by: Kumar Gala <kumar.gala@linaro.org>
2020-05-28 00:26:57 +08:00
uint32_t i;
coccinelle: irq_lock.cocci: Update script * Provide a single liner description at top using `///` comments. This one liner is displayed when using `--verbose` mode of coccicheck. * Specify Condidence level property adhering to coccinelle.rst section "Proposing new semantic patches". * Add virtual patch rule to handle the patch case when coccicheck is supplied with `--mode=patch` option. * Add `depends on !(file in "ext")` to ignore reports from `ext/` directory. * Simplify rule to use disjunctions and use "exists" to match any available control path. Suggested-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
2018-11-06 01:57:43 +08:00
|
- T
+ unsigned int
i;
...
i = irq_lock();
)