2016-11-08 23:36:50 +08:00
|
|
|
/*
|
|
|
|
* Copyright (c) 2016 Wind River Systems, Inc.
|
|
|
|
*
|
2017-01-19 09:01:01 +08:00
|
|
|
* SPDX-License-Identifier: Apache-2.0
|
2016-11-08 23:36:50 +08:00
|
|
|
*/
|
|
|
|
|
|
|
|
#ifndef _offsets_short_arch__h_
|
|
|
|
#define _offsets_short_arch__h_
|
|
|
|
|
|
|
|
#include <offsets.h>
|
|
|
|
|
|
|
|
/* kernel */
|
|
|
|
|
|
|
|
/* nothing for now */
|
|
|
|
|
|
|
|
/* end - kernel */
|
|
|
|
|
|
|
|
/* threads */
|
|
|
|
|
|
|
|
#define _thread_offset_to_basepri \
|
|
|
|
(___thread_t_arch_OFFSET + ___thread_arch_t_basepri_OFFSET)
|
|
|
|
|
kernel/arm: fix race condition when setting _Swap() return value
There was a possible race condition when setting the return value of a
thread that is pending, from an ISR.
A kernel function causes a thread to pend, with the following series of
steps:
- disable interrupts
- move current thread to wait_q
- call _Swap
Depending if running on M3/4 or M0+, _Swap will either issue a svc #0,
or pend PendSV directly. The same problem exists in both cases.
M3/4:
__svc will:
- enable interrupts
- trigger __pendsv
M0+:
_Swap() will enable interrupts.
__pendsv will:
- save register context including PSP into the thread struct
If an interrupt occurs between interrupts being enabled them and
__pendsv saving PSP, and the ISR sets the pending thread's return value,
this will happen:
- sees the thread in a wait_q
- removes it
- makes it ready
- calls _set_thread_return_value
- _set_thread_return_value looks at the thread's saved PSP to poke
the value
In this scenario, PSP hasn't yet been updated by __pendsv so it's a
stale value from the previous context switch, resulting in unpredictable
word on the stack getting set to the return value.
There is no way to fix this issue and still have the return value being
delivered directly in the pending thread's exception stack frame, in the
M0+ case. There will always be a window between the unlocking of
interrupts and PendSV being handled. On M3/4, it could be possible with
the mix of SVC and PendSV, since the exception stack frame is created in
the __svc handler. However, because we want to keep the two
implementations as close as possible, and there were talks of moving
M3/4 to using PendSV only, to save an exception, the approach taken
solves both cases.
The approach taken is similar to the ARC and Nios2 ports, where
there is a field in the thread structure that holds the return value.
_Swap() then loads r0/a1 with that value just before returning.
Fixes ZEP-1289.
Change-Id: Iee7e06fe3f8ded84aff918fd43408c7f589344d9
Signed-off-by: Benjamin Walsh <benjamin.walsh@windriver.com>
2016-11-16 07:45:43 +08:00
|
|
|
#define _thread_offset_to_swap_return_value \
|
|
|
|
(___thread_t_arch_OFFSET + ___thread_arch_t_swap_return_value_OFFSET)
|
|
|
|
|
2016-11-08 23:36:50 +08:00
|
|
|
#define _thread_offset_to_preempt_float \
|
|
|
|
(___thread_t_arch_OFFSET + ___thread_arch_t_preempt_float_OFFSET)
|
|
|
|
|
|
|
|
/* end - threads */
|
|
|
|
|
|
|
|
#endif /* _offsets_short_arch__h_ */
|