Commit Graph

2 Commits

Author SHA1 Message Date
Martí Bolívar 36cb8829ad test_commands.py: improve coverage
Add white box test for new behavior of returning None on mismatch.

Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
2022-08-31 16:06:42 -07:00
Martí Bolívar 4808c626e2 commands: fix git version detection on macOS
I ran into this testing 0.11.0a1. Our current code matches against the
last word in the 'git --version' output. Unfortunately, for 'git
version 2.24.3 (Apple Git-128)', that's incorrectly matching against
'Git-128)', which doesn't work.

Generalize the version detection a bit to handle this, and add
regression tests.

Signed-off-by: Martí Bolívar <marti.bolivar@nordicsemi.no>
2021-05-03 14:37:10 -07:00