linux/net/tipc
Tung Nguyen 303d062881 tipc: fix unexpected link reset due to discovery messages
[ Upstream commit c244c092f1 ]

This unexpected behavior is observed:

node 1                    | node 2
------                    | ------
link is established       | link is established
reboot                    | link is reset
up                        | send discovery message
receive discovery message |
link is established       | link is established
send discovery message    |
                          | receive discovery message
                          | link is reset (unexpected)
                          | send reset message
link is reset             |

It is due to delayed re-discovery as described in function
tipc_node_check_dest(): "this link endpoint has already reset
and re-established contact with the peer, before receiving a
discovery message from that node."

However, commit 598411d70f has changed the condition for calling
tipc_node_link_down() which was the acceptance of new media address.

This commit fixes this by restoring the old and correct behavior.

Fixes: 598411d70f ("tipc: make resetting of links non-atomic")
Acked-by: Jon Maloy <jmaloy@redhat.com>
Signed-off-by: Tung Nguyen <tung.q.nguyen@dektech.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-01-18 11:48:54 +01:00
..
Kconfig
Makefile
addr.c
addr.h
bcast.c
bcast.h
bearer.c
bearer.h
core.c
core.h
crypto.c tipc: re-fetch skb cb after tipc_msg_validate 2022-12-08 11:28:41 +01:00
crypto.h
diag.c
discover.c tipc: check skb_linearize() return value in tipc_disc_rcv() 2022-12-02 17:41:06 +01:00
discover.h
eth_media.c
group.c
group.h
ib_media.c
link.c tipc: Fix potential OOB in tipc_link_proto_rcv() 2022-12-14 11:37:28 +01:00
link.h
monitor.c
monitor.h
msg.c
msg.h
name_distr.c
name_distr.h
name_table.c
name_table.h
net.c
net.h
netlink.c
netlink.h
netlink_compat.c
node.c tipc: fix unexpected link reset due to discovery messages 2023-01-18 11:48:54 +01:00
node.h
socket.c
socket.h
subscr.c
subscr.h
sysctl.c
topsrv.c tipc: add an extra conn_get in tipc_conn_alloc 2022-12-02 17:41:06 +01:00
topsrv.h
trace.c
trace.h
udp_media.c
udp_media.h