linux/net/l2tp
Eric Dumazet b2a7309743 l2tp: prevent lockdep issue in l2tp_tunnel_register()
[ Upstream commit b9fb10d131 ]

lockdep complains with the following lock/unlock sequence:

     lock_sock(sk);
     write_lock_bh(&sk->sk_callback_lock);
[1]  release_sock(sk);
[2]  write_unlock_bh(&sk->sk_callback_lock);

We need to swap [1] and [2] to fix this issue.

Fixes: 0b2c59720e ("l2tp: close all race conditions in l2tp_tunnel_register()")
Reported-by: syzbot+bbd35b345c7cab0d9a08@syzkaller.appspotmail.com
Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/netdev/20230114030137.672706-1-xiyou.wangcong@gmail.com/T/#m1164ff20628671b0f326a24cb106ab3239c70ce3
Cc: Cong Wang <cong.wang@bytedance.com>
Cc: Guillaume Nault <gnault@redhat.com>
Reviewed-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-02-01 08:27:12 +01:00
..
Kconfig
Makefile
l2tp_core.c l2tp: prevent lockdep issue in l2tp_tunnel_register() 2023-02-01 08:27:12 +01:00
l2tp_core.h
l2tp_debugfs.c
l2tp_eth.c
l2tp_ip.c
l2tp_ip6.c
l2tp_netlink.c
l2tp_ppp.c
trace.h