OrgRaspberrypi
/
linux
mirror of https://github.com/raspberrypi/linux.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

net: emaclite: don't call dev_kfree_skb() under spin_lock_irqsave() 

It is not allowed to call kfree_skb() or consume_skb() from hardware
interrupt context or with hardware interrupts being disabled.

It should use dev_kfree_skb_irq() or dev_consume_skb_irq() instead.
The difference between them is free reason, dev_kfree_skb_irq() means
the SKB is dropped in error and dev_consume_skb_irq() means the SKB
is consumed in normal.

In this case, dev_kfree_skb() is called in xemaclite_tx_timeout() to
drop the SKB, when tx timeout, so replace it with dev_kfree_skb_irq().

Fixes: bb81b2ddfa ("net: add Xilinx emac lite device driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Yang Yingliang 2022-12-08 22:21:44 +08:00 committed by David S. Miller
parent 5fe02e046e
commit d1678bf45f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/xilinx/xilinx_emaclite.c
View File

@ -536,7 +536,7 @@ static void xemaclite_tx_timeout(struct net_device *dev, unsigned int txqueue)
xemaclite_enable_interrupts(lp); xemaclite_enable_interrupts(lp);
if (lp->deferred_skb) { if (lp->deferred_skb) {
dev_kfree_skb(lp->deferred_skb); dev_kfree_skb_irq(lp->deferred_skb);
lp->deferred_skb = NULL; lp->deferred_skb = NULL;
dev->stats.tx_errors++; dev->stats.tx_errors++;
} }