From 869097c809234f25fd1115d6d21383688b31bb3e Mon Sep 17 00:00:00 2001 From: Davis King Date: Sat, 16 Jan 2021 10:13:19 -0500 Subject: [PATCH] Make setup.py errors about cmake not being installed more readable --- setup.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/setup.py b/setup.py index a3f7bbe0e..8e4330986 100644 --- a/setup.py +++ b/setup.py @@ -118,18 +118,17 @@ class CMakeBuild(build_ext): def get_cmake_version(self): try: out = subprocess.check_output(['cmake', '--version']) - except OSError: - raise RuntimeError("\n*******************************************************************\n" + - " CMake must be installed to build the following extensions: " + - ", ".join(e.name for e in self.extensions) + - "\n*******************************************************************\n") + except: + sys.stderr.write("\nERROR: CMake must be installed to build dlib\n\n") + sys.exit(1) return re.search(r'version\s*([\d.]+)', out.decode()).group(1) def run(self): cmake_version = self.get_cmake_version() if platform.system() == "Windows": if LooseVersion(cmake_version) < '3.1.0': - raise RuntimeError("CMake >= 3.1.0 is required on Windows") + sys.stderr.write("\nERROR: CMake >= 3.1.0 is required on Windows\n\n") + sys.exit(1) for ext in self.extensions: self.build_extension(ext)