OrgLion-ML
/
dlib
mirror of https://github.com/davisking/dlib.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix setting a point's y coordinate changes x instead (Python bindings) (#1795) 

* Add point assignment test

* Fix setting points y coordinate changes x instead (issue #1794)
This commit is contained in:
mchelem 2019-06-08 07:08:45 -03:00 committed by Davis E. King
parent 22402e99a0
commit 5d64de24b3
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/python/src/vector.cpp
View File

@ -432,7 +432,7 @@ void bind_vector(py::module& m)
.def(double() * py::self) .def(double() * py::self)
.def("normalize", &type::normalize, "Returns a unit normalized copy of this vector.") .def("normalize", &type::normalize, "Returns a unit normalized copy of this vector.")
.def_property("x", &point_x, [](point& p, long x){p.x()=x;}, "The x-coordinate of the point.") .def_property("x", &point_x, [](point& p, long x){p.x()=x;}, "The x-coordinate of the point.")
.def_property("y", &point_y, [](point& p, long y){p.x()=y;}, "The y-coordinate of the point.") .def_property("y", &point_y, [](point& p, long y){p.y()=y;}, "The y-coordinate of the point.")
.def(py::pickle(&getstate<type>, &setstate<type>)); .def(py::pickle(&getstate<type>, &setstate<type>));
} }
{ {

8
tools/python/test/test_point.py
View File

@ -16,6 +16,14 @@ def test_point():
assert deser.x == p.x assert deser.x == p.x
assert deser.y == p.y assert deser.y == p.y
def test_point_assignment():
p = point(27, 42)
p.x = 16
assert p.x == 16
assert p.y == 42
p.y = 31
assert p.x == 16
assert p.y == 31
def test_point_init_kwargs(): def test_point_init_kwargs():
p = point(y=27, x=42) p = point(y=27, x=42)