Commit Graph

7 Commits

Author SHA1 Message Date
Xingyi Zhou d56bfd94cf fix pascal data setup 2019-04-22 22:36:50 -05:00
cclauss 1316d370fe
Add comments to explain why nms = None
Explicit is better than implicit.
2019-04-21 08:10:15 +02:00
Xingyi Zhou 88fafa1b0f
Revert "from model.nms_wrapper import nms for lines 132 and 168" 2019-04-20 22:05:48 -07:00
cclauss 922228813b
from model.nms_wrapper import nms for lines 132 and 168
[flake8](http://flake8.pycqa.org) testing of https://github.com/xingyizhou/CenterNet on Python 3.7.1

$ __flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics__
```
./src/lib/models/networks/dlav0.py:417:5: F821 undefined name 'dla'
    dla.BatchNorm = bn
    ^
./src/tools/voc_eval_lib/model/test.py:132:14: F821 undefined name 'nms'
      keep = nms(dets, thresh)
             ^
./src/tools/voc_eval_lib/model/test.py:168:14: F821 undefined name 'nms'
      keep = nms(cls_dets, cfg.TEST.NMS)
             ^
3     F821 undefined name 'dla'
3
```
__E901,E999,F821,F822,F823__ are the "_showstopper_" [flake8](http://flake8.pycqa.org) issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.
* F821: undefined name `name`
* F822: undefined name `name` in `__all__`
* F823: local variable name referenced before assignment
* E901: SyntaxError or IndentationError
* E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
2019-04-20 08:32:41 +02:00
Xingyi Zhou d19b524315 fix legacy typos in code 2019-04-18 17:42:04 -05:00
cclauss d0067e886d
Undefined name: opt.K --> self.opt.K 2019-04-18 10:13:10 +02:00
Xingyi Zhou f16ef636dd init 2019-04-16 13:36:21 -05:00