From 20b8a067075bb00430b0f1469968a14fbd712c8a Mon Sep 17 00:00:00 2001 From: Oliver <480930+rivo@users.noreply.github.com> Date: Thu, 11 Aug 2022 22:34:03 +0200 Subject: [PATCH] Not promoting a mouse-up event to a click event when it was prevented by a mouse capture. See #752 --- application.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/application.go b/application.go index e2f4e2d..8f90393 100644 --- a/application.go +++ b/application.go @@ -60,9 +60,9 @@ type queuedUpdate struct { // The following command displays a primitive p on the screen until Ctrl-C is // pressed: // -// if err := tview.NewApplication().SetRoot(p, true).Run(); err != nil { -// panic(err) -// } +// if err := tview.NewApplication().SetRoot(p, true).Run(); err != nil { +// panic(err) +// } type Application struct { sync.RWMutex @@ -460,8 +460,8 @@ func (a *Application) fireMouseActions(event *tcell.EventMouse) (consumed, isMou if buttons&buttonEvent.button != 0 { fire(buttonEvent.down) } else { - fire(buttonEvent.up) - if !clickMoved { + fire(buttonEvent.up) // A user override might set event to nil. + if !clickMoved && event != nil { if a.lastMouseClick.Add(DoubleClickInterval).Before(time.Now()) { fire(buttonEvent.click) a.lastMouseClick = time.Now()