http: Only enable access logs if configured

This commit is contained in:
Matthew Holt 2019-11-15 17:01:07 -07:00
parent 8025ad9107
commit af26a03da1
No known key found for this signature in database
GPG Key ID: 2A349DD577D586A5
2 changed files with 6 additions and 1 deletions

View File

@ -76,9 +76,13 @@ func (app *App) Provision(ctx caddy.Context) error {
for srvName, srv := range app.Servers {
srv.logger = app.logger.Named("log")
srv.accessLogger = app.logger.Named("log.access")
srv.errorLogger = app.logger.Named("log.error")
// only enable access logs if configured
if srv.Logs != nil {
srv.accessLogger = app.logger.Named("log.access")
}
if srv.AutoHTTPS == nil {
// avoid nil pointer dereferences
srv.AutoHTTPS = new(AutoHTTPSConfig)

View File

@ -229,6 +229,7 @@ func (rr *responseRecorder) WriteResponse() error {
_, err := io.Copy(rr.ResponseWriterWrapper, rr.buf)
return err
}
// ResponseRecorder is a http.ResponseWriter that records
// responses instead of writing them to the client. See
// docs for NewResponseRecorder for proper usage.