httpcaddyfile: Put root directive first, before redir and rewrite

See https://caddy.community/t/v2-match-any-path-but-files/7326/8?u=matt

If rewrites (or redirects, for that matter) match on file existence,
the file matcher would need to know the root of the site.

Making this change implies that root directives that depend on rewritten
URIs will not work as expected. However, I think this is very uncommon,
and am not sure I have ever seen that. Usually, dynamic roots are based
on host, not paths or query strings.

I suspect that rewrites based on file existence will be more common than
roots based on rewritten URIs, so I am moving root to be the first in
the list.

Users can always override this ordering with the 'order' global option.
This commit is contained in:
Matthew Holt 2020-03-28 19:07:51 -06:00
parent e207240f9a
commit 178ba024fe
No known key found for this signature in database
GPG Key ID: 2A349DD577D586A5
2 changed files with 11 additions and 2 deletions

View File

@ -27,14 +27,21 @@ import (
// directiveOrder specifies the order // directiveOrder specifies the order
// to apply directives in HTTP routes. // to apply directives in HTTP routes.
//
// The root directive goes first in case rewrites or
// redirects depend on existence of files, i.e. the
// file matcher, which must know the root first.
//
// The header directive goes second so that headers
// can be manipulated before doing redirects.
var directiveOrder = []string{ var directiveOrder = []string{
"root",
"header", "header",
"redir", "redir",
"rewrite", "rewrite",
"root",
// URI manipulation // URI manipulation
"uri", "uri",
"try_files", "try_files",

View File

@ -199,6 +199,8 @@ func StatusCodeMatches(actual, configured int) bool {
// tlsPlaceholderWrapper is a no-op listener wrapper that marks // tlsPlaceholderWrapper is a no-op listener wrapper that marks
// where the TLS listener should be in a chain of listener wrappers. // where the TLS listener should be in a chain of listener wrappers.
// It should only be used if another listener wrapper must be placed
// in front of the TLS handshake.
type tlsPlaceholderWrapper struct{} type tlsPlaceholderWrapper struct{}
func (tlsPlaceholderWrapper) CaddyModule() caddy.ModuleInfo { func (tlsPlaceholderWrapper) CaddyModule() caddy.ModuleInfo {