From f7c68a80b43e40e69b074f2cc47ccec769b12b75 Mon Sep 17 00:00:00 2001
From: M M Arif <mmarif@swatian.com>
Date: Wed, 15 May 2024 05:38:44 +0000
Subject: [PATCH] Fix attachments for comments and improve comment UI (#1358)

As title

Reviewed-on: https://codeberg.org/gitnex/GitNex/pulls/1358
Co-authored-by: M M Arif <mmarif@swatian.com>
Co-committed-by: M M Arif <mmarif@swatian.com>
---
 .../mian/gitnex/adapters/IssueCommentsAdapter.java   | 12 ++++++++----
 app/src/main/res/layout/activity_issue_detail.xml    | 12 ++++++------
 app/src/main/res/values/dimens.xml                   |  1 +
 3 files changed, 15 insertions(+), 10 deletions(-)

diff --git a/app/src/main/java/org/mian/gitnex/adapters/IssueCommentsAdapter.java b/app/src/main/java/org/mian/gitnex/adapters/IssueCommentsAdapter.java
index 64b59946..a069092c 100644
--- a/app/src/main/java/org/mian/gitnex/adapters/IssueCommentsAdapter.java
+++ b/app/src/main/java/org/mian/gitnex/adapters/IssueCommentsAdapter.java
@@ -260,10 +260,14 @@ public class IssueCommentsAdapter extends RecyclerView.Adapter<RecyclerView.View
 
 			String token = ((BaseActivity) context).getAccount().getAccount().getToken();
 
-			if (issueComment != null) {
-				new Handler()
-						.postDelayed(() -> getAttachments(issueComment.getId(), view, token), 250);
-			}
+			new Handler()
+					.postDelayed(
+							() -> {
+								if (issueComment != null) {
+									getAttachments(issueComment.getId(), view, token);
+								}
+							},
+							250);
 
 			menu.setOnClickListener(
 					v -> {
diff --git a/app/src/main/res/layout/activity_issue_detail.xml b/app/src/main/res/layout/activity_issue_detail.xml
index b1b6b679..a758fa50 100644
--- a/app/src/main/res/layout/activity_issue_detail.xml
+++ b/app/src/main/res/layout/activity_issue_detail.xml
@@ -406,22 +406,22 @@
                 android:paddingTop="@dimen/dimen8dp"
                 android:paddingBottom="@dimen/dimen8dp"
                 android:textColor="?attr/inputTextColor"
-                android:layout_marginEnd="@dimen/dimen12dp"
-                android:textSize="@dimen/dimen14sp" />
+                android:layout_marginEnd="@dimen/dimen8dp"
+                android:textSize="@dimen/dimen16sp" />
 
             <com.google.android.material.card.MaterialCardView
                 style="?attr/materialCardViewFilledStyle"
                 android:id="@+id/send_button"
-                android:layout_width="@dimen/dimen36dp"
-                android:layout_height="@dimen/dimen36dp"
+                android:layout_width="@dimen/dimen38dp"
+                android:layout_height="@dimen/dimen38dp"
                 android:layout_gravity="center_vertical"
                 android:backgroundTint="?attr/fabColor"
                 app:cardCornerRadius="@dimen/dimen36dp">
 
                <ImageView
                    android:id="@+id/send"
-                   android:layout_width="@dimen/dimen24dp"
-                   android:layout_height="@dimen/dimen24dp"
+                   android:layout_width="@dimen/dimen26dp"
+                   android:layout_height="@dimen/dimen26dp"
                    android:layout_gravity="center_vertical|center_horizontal"
                    android:contentDescription="@string/generalImgContentText"
                    app:tint="?attr/materialCardBackgroundColor"
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
index 1e9d2374..1beddcf6 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -17,6 +17,7 @@
     <dimen name="dimen28dp">28dp</dimen>
     <dimen name="dimen32dp">32dp</dimen>
     <dimen name="dimen36dp">36dp</dimen>
+    <dimen name="dimen38dp">38dp</dimen>
     <dimen name="dimen40dp">40dp</dimen>
     <dimen name="dimen44dp">44dp</dimen>
     <dimen name="dimen48dp">48dp</dimen>