From b84c7f48996a9bbacdddcef9929405f674a73a81 Mon Sep 17 00:00:00 2001 From: Guiding Li Date: Wed, 20 Feb 2019 11:36:57 +0800 Subject: [PATCH 3/3] rpmsg: wait endpoint ready in rpmsg_send and rpmsg_send_nocopy because the remote need time to return the destination address Signed-off-by: Guiding Li --- lib/include/openamp/rpmsg.h | 59 ++++++++++++++++++++++++++----------- lib/rpmsg/rpmsg_virtio.c | 7 ----- 2 files changed, 42 insertions(+), 24 deletions(-) diff --git a/lib/include/openamp/rpmsg.h open-amp/lib/include/openamp/rpmsg.h index efdfb2b..5c8b45c 100644 --- a/lib/include/openamp/rpmsg.h +++ open-amp/lib/include/openamp/rpmsg.h @@ -15,6 +15,7 @@ #include #include #include +#include #include #include #include @@ -32,6 +33,12 @@ extern "C" { #define RPMSG_RESERVED_ADDRESSES (1024) #define RPMSG_ADDR_ANY 0xFFFFFFFF +/* Total tick count for 15secs - 1usec tick. */ +#define RPMSG_TICK_COUNT 15000000 + +/* Time to wait - In multiple of 1 msecs. */ +#define RPMSG_TICKS_PER_INTERVAL 1000 + /* Error macros. */ #define RPMSG_SUCCESS 0 #define RPMSG_ERROR_BASE -2000 @@ -141,6 +148,19 @@ int rpmsg_send_offchannel_raw(struct rpmsg_endpoint *ept, uint32_t src, uint32_t dst, const void *data, int len, int wait); +/** + * is_rpmsg_ept_ready - check if the rpmsg endpoint ready to send + * + * @ept: pointer to rpmsg endpoint + * + * Returns 1 if the rpmsg endpoint has both local addr and destination + * addr set, 0 otherwise + */ +static inline unsigned int is_rpmsg_ept_ready(struct rpmsg_endpoint *ept) +{ + return ept && ept->rdev && ept->dest_addr != RPMSG_ADDR_ANY; +} + /** * rpmsg_send() - send a message across to the remote processor * @ept: the rpmsg endpoint @@ -159,8 +179,17 @@ int rpmsg_send_offchannel_raw(struct rpmsg_endpoint *ept, uint32_t src, static inline int rpmsg_send(struct rpmsg_endpoint *ept, const void *data, int len) { - return rpmsg_send_offchannel_raw(ept, ept->addr, ept->dest_addr, data, - len, true); + int tc = 0; + + for (; tc < RPMSG_TICK_COUNT; tc += RPMSG_TICKS_PER_INTERVAL) { + if (is_rpmsg_ept_ready(ept)) + return rpmsg_send_offchannel_raw(ept, ept->addr, + ept->dest_addr, + data, len, true); + metal_sleep_usec(RPMSG_TICKS_PER_INTERVAL); + } + + return RPMSG_ERR_ADDR; } /** @@ -433,8 +462,17 @@ static inline int rpmsg_sendto_nocopy(struct rpmsg_endpoint *ept, static inline int rpmsg_send_nocopy(struct rpmsg_endpoint *ept, const void *data, int len) { - return rpmsg_send_offchannel_nocopy(ept, ept->addr, - ept->dest_addr, data, len); + int tc = 0; + + for (; tc < RPMSG_TICK_COUNT; tc += RPMSG_TICKS_PER_INTERVAL) { + if (is_rpmsg_ept_ready(ept)) + return rpmsg_send_offchannel_nocopy(ept, ept->addr, + ept->dest_addr, + data, len); + metal_sleep_usec(RPMSG_TICKS_PER_INTERVAL); + } + + return RPMSG_ERR_ADDR; } /** @@ -507,19 +545,6 @@ int rpmsg_create_ept(struct rpmsg_endpoint *ept, struct rpmsg_device *rdev, */ void rpmsg_destroy_ept(struct rpmsg_endpoint *ept); -/** - * is_rpmsg_ept_ready - check if the rpmsg endpoint ready to send - * - * @ept: pointer to rpmsg endpoint - * - * Returns 1 if the rpmsg endpoint has both local addr and destination - * addr set, 0 otherwise - */ -static inline unsigned int is_rpmsg_ept_ready(struct rpmsg_endpoint *ept) -{ - return ept && ept->rdev && ept->dest_addr != RPMSG_ADDR_ANY; -} - #if defined __cplusplus } #endif diff --git a/lib/rpmsg/rpmsg_virtio.c open-amp/lib/rpmsg/rpmsg_virtio.c index 164dc70..c357ba8 100644 --- a/lib/rpmsg/rpmsg_virtio.c +++ open-amp/lib/rpmsg/rpmsg_virtio.c @@ -8,7 +8,6 @@ */ #include -#include #include #include #include @@ -17,12 +16,6 @@ #define RPMSG_NUM_VRINGS 2 -/* Total tick count for 15secs - 1usec tick. */ -#define RPMSG_TICK_COUNT 15000000 - -/* Time to wait - In multiple of 1 msecs. */ -#define RPMSG_TICKS_PER_INTERVAL 1000 - #ifndef VIRTIO_SLAVE_ONLY metal_weak void * rpmsg_virtio_shm_pool_get_buffer(struct rpmsg_virtio_shm_pool *shpool, -- 2.17.1