We're running linkcheck and ignoring errors but this still slows CI build
and can even make it fail due to timeout. The linkcheck is useful for local
manual test but not really for CI.
We are seeing higher cases of artifact upload failures
in github. Other projects are also seeing this as has been
reported at https://github.com/actions/upload-artifact/issues/116
There is a fix that was just merged in the base library:
https://github.com/actions/toolkit/pull/675
So Hopefully we can revert this before too long.
Signed-off-by: Brennan Ashton <bashton@brennanashton.com>
Add new option -A is added to tools/testbuild.sh that will take the
created build executable and store it in a folder for the config
that generated it under $ARTIFACTDIR which can be set via an
environment variable or defaulted to $(TOPDIR)/buildartifacts
This is also helpful for local testing because you can now run
tools/testbuild.sh -A sim.dat and have all of the simulation
targets generated without having to rebuild along the way.
In the GitHub Actions workflow the artifacs are uploaded
two two bundles one for macOS and one for Linux
Signed-off-by: Brennan Ashton <bashton@brennanashton.com>
This reverts commit 350131d00e.
If one PR is on a former master code base, using 'git diff $commits' would result in
abnormal checkpatch report sometimes. So revert it anyway.
Something change on the GitHub side that has broken credentials
between the the fetch and buld workflow steps. There is no
way to tell the checkout action to only re-auth so we have it
checkout the repo again, but it will use what it already has.
In the future we can change fetch step to just compute the
target refs and store them in a script that we can call to
set the environment variables for the targets much like
this patch.
Signed-off-by: Brennan Ashton <bashton@brennanashton.com>
So far, the use of the new pull request template has been disastrous. People are ignoring the writing instructions the template is polluting the PR history. This change just removes the boilerplate and writing instructions fromt he template. We don't need to see this unmodified serveral times per day.
There is chance pull docker container failure in build jobs,
remove the additional pull docker container step may make it
more stable. Meanwhile, it also saves some time for build job.
Signed-off-by: liuhaitao <liuhaitao@xiaomi.com>
Matias N