OrgApache/incubator-nuttx
OrgApache
/
incubator-nuttx
mirror of https://github.com/apache/incubator-nuttx.git
1
0
Fork 0
Code Issues Releases Wiki Activity
55,162 Commits 18 Branches 185 Tags 440 MiB
Commit Graph

188 Commits

Author SHA1 Message Date
zhengyu9 70a91289dd fs: fdcheck can't assert 
while running fdcheck_test_common there should be assertion failed

Signed-off-by: zhengyu9 <zhengyu9@xiaomi.com>
 2024-10-03 14:22:55 +08:00
dongjiuzhu1 b2e69b86ad fs/inode: remove unnecessary return value for inode_addrefs 
Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
 2024-10-02 01:56:46 +08:00
dongjiuzhu1 09a9611ae9 fs/inode: using rwsem lock as inode_lock to avoid deadlock 
Example:
When executing "df -h" on Core A to view mount information, this
process will traverse inode nodes, thereby holding the inode_lock.
Since the inode type of the mount point may be rpmsgfs, it will fetch statfs
information from another Core B.

Meanwhile, rcS on Core B needs to obtain file information from Core A,
which will be achieved by fetching stat information through rpmsgfs.
When this message arrives at Core A, a deadlock can occur between Core A's
rptun ap and nsh task.

However, both of these places involve read operations only, thus a reader-writer lock
can be utilized to prevent such a deadlock.

Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
 2024-10-02 01:56:46 +08:00
chenrun1 96206cbf9d fs/xxfs:Replace kmm with fs heap 
Summary:
  1.Add configuration to allocate memory from the specified section
  2.Replace all memory operations (kmm_) in the vfs with
    fs_heap_. When FS_HEAPSIZE > 0, memory is requested for the file system by specifying a configured heap location. By default (i.e. FS_HEAPSIZE=0) fs_heap_ is equivalent to kmm_

Signed-off-by: chenrun1 <chenrun1@xiaomi.com>
 2024-09-30 16:30:56 +08:00
zhangshoukui 7e97691452 Should call fs_putfilep put fs reference when call files_fget complete 
Signed-off-by: zhangshoukui <zhangshoukui@xiaomi.com>
 2024-09-23 18:22:35 +08:00
chenrun1 4cec713dbf fs_inode:Change the type of i_crefs to atomic_int 
Summary:
  1.Modified the i_crefs from int16_t to atomic_int
  2.Modified the i_crefs add, delete, read, and initialize interfaces to atomic operations
The purpose of this change is to avoid deadlock in cross-core scenarios, where A Core blocks B Core’s request for a write operation to A Core when A Core requests a read operation to B Core.

Signed-off-by: chenrun1 <chenrun1@xiaomi.com>
 2024-09-23 14:07:03 +08:00
chenrun1 d04205aa3d fs/mmap/msync:support msync. 
Summary:
  1.Added msync callback in struct mm_map_entry_s
  2.Added msync API in fs_msync.c
  3.Added static msync_rammap for rammap.

Signed-off-by: chenrun1 <chenrun1@xiaomi.com>
 2024-09-19 01:43:50 +08:00
chao an 3cce16dd0c fs/dump: correct SCHED_DUMP_ON_EXIT to DUMP_ON_EXIT 
1. correct SCHED_DUMP_ON_EXIT to DUMP_ON_EXIT
2. dump file list only if DUMP_ON_EXIT enabled

Signed-off-by: chao an <anchao@lixiang.com>
 2024-09-18 23:48:31 +08:00
zhangshoukui baa716a85d fs: Dump the list of files when the file description runs out 
Signed-off-by: zhangshoukui <zhangshoukui@xiaomi.com>
 2024-09-18 13:48:45 +08:00
zhangshoukui 13dd7bbfb3 Add reference count configuration 
Signed-off-by: zhangshoukui <zhangshoukui@xiaomi.com>
 2024-09-17 12:01:53 +08:00
zhangshoukui 0b084308ba Fix Multiple close fd when SMP enable 
task1:
The refs is 0 but the inode has not been released
task2:
Executing files_duplist, get filep with refs is zero, but the inode has not yet released.

[    0.530600] [CPU1] [ 6] [ ALERT] [ap] sched_dumpstack: backtrace:
[    0.530800] [CPU1] [ 6] [ ALERT] [ap] sched_dumpstack: [ 6] [<0x4045172>] backtrace_unwind+0x241/0x244
[    0.531200] [CPU1] [ 6] [ ALERT] [ap] sched_dumpstack: [ 6] [<0x4009150>] sched_backtrace+0x27/0x4c
[    0.531500] [CPU1] [ 6] [ ALERT] [ap] sched_dumpstack: [ 6] [<0x402f0fa>] sched_dumpstack+0x3d/0xa0
[    0.531700] [CPU1] [ 6] [ ALERT] [ap] sched_dumpstack: [ 6] [<0x4002c90>] _assert+0x1e3/0x564
[    0.532000] [CPU1] [ 6] [ ALERT] [ap] sched_dumpstack: [ 6] [<0x40221f6>] __assert+0x19/0x24
[    0.532200] [CPU1] [ 6] [ ALERT] [ap] sched_dumpstack: [ 6] [<0x41fe376>] tcp_stop_monitor+0x61/0x6c
[    0.532500] [CPU1] [ 6] [ ALERT] [ap] sched_dumpstack: [ 6] [<0x41fe19e>] tcp_close+0xad/0xdc
[    0.532700] [CPU1] [ 6] [ ALERT] [ap] sched_dumpstack: [ 6] [<0x41ecc18>] inet_close+0x7b/0x8c
[    0.533000] [CPU1] [ 6] [ ALERT] [ap] sched_dumpstack: [ 6] [<0x41ec374>] psock_close+0x27/0x70
[    0.533300] [CPU1] [ 6] [ ALERT] [ap] sched_dumpstack: [ 6] [<0x420b68e>] sock_file_close+0x15/0x3c
[    0.533500] [CPU1] [ 6] [ ALERT] [ap] sched_dumpstack: [ 6] [<0x4206704>] file_close+0x1f/0x80
[    0.533800] [CPU1] [ 6] [ ALERT] [ap] sched_dumpstack: [ 6] [<0x4205278>] files_duplist+0x39f/0x45c
[    0.534100] [CPU1] [ 6] [ ALERT] [ap] sched_dumpstack: [ 6] [<0x4000e3c>] group_setuptaskfiles+0x57/0xc0
[    0.534300] [CPU1] [ 6] [ ALERT] [ap] sched_dumpstack: [ 6] [<0x400bc6c>] nxtask_init+0x5b/0x13c

Signed-off-by: zhangshoukui <zhangshoukui@xiaomi.com>
 2024-09-17 12:01:53 +08:00
Shoukui Zhang 43223124ec vfs/file: add reference counting to prevent accidental close during reading writing... 
Signed-off-by: Shoukui Zhang <zhangshoukui@xiaomi.com>
 2024-09-17 12:01:53 +08:00
dongjiuzhu1 00e878e848 fs/inode: add reference to protect filelist of group 
Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
 2024-09-10 15:16:19 +08:00
dongjiuzhu1 43d0d95f81 fs/inode: using inode reference to indicate unlink and simply code 
Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
 2024-09-09 08:42:34 +08:00
dongjiuzhu1 2a8c023357 fs/inode: using orig_row to ensure correct free logic 
Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
 2024-09-09 01:24:08 +08:00
dongjiuzhu1 6542806248 fs/inode: fix assert when free error address 
Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
 2024-09-09 01:24:08 +08:00
hujun5 198630a809 sched: use this_task replace nxsched_self 
reason:
We can reduce a function call to improve performance.
Signed-off-by: hujun5 <hujun5@xiaomi.com>
 2024-09-05 09:33:50 -03:00
Petro Karashchenko d499ac9d58 nuttx: fix multiple 'FAR', 'CODE' and style issues 
Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
 2024-08-25 19:22:15 +08:00
cuiziwei 71d10bd8cf nuttx/fs:Rename node with inode. 
Signed-off-by: cuiziwei <cuiziwei@xiaomi.com>
 2024-08-19 13:35:56 +08:00
hujun5 a4fece3450 spin_lock: inline spin_lock 
test:
We can use qemu for testing.
compiling
make distclean -j20; ./tools/configure.sh -l qemu-armv8a:nsh_smp ;make -j20
running
qemu-system-aarch64 -cpu cortex-a53 -smp 4 -nographic -machine virt,virtualization=on,gic-version=3 -net none -chardev stdio,id=con,mux=on -serial chardev:con -mon chardev=con,mode=readline -kernel ./nuttx
 2024-07-15 02:29:30 +08:00
chao an f857004227 fs/procfs: refine file backtrace 
remove backtrace arrary in stack

Signed-off-by: chao an <anchao@lixiang.com>
 2024-06-30 17:30:42 +08:00
yinshengkai 5a31d52fd8 files: add files_dumplist api, replace dumponexit implementation 
Signed-off-by: yinshengkai <yinshengkai@xiaomi.com>
 2024-06-30 17:30:42 +08:00
Xu Xingliang b0698daaa4 fs: tweak backtrace for file open 
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
 2024-06-30 17:30:42 +08:00
Xu Xingliang 69d8a17dda fs: add backtrace to where file opens 
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
 2024-06-24 23:53:59 +08:00
chao an e456c88c09 Revert "sched: replace some global variables to macro" 
sched implementation not depends on macro abstraction, so revert below commit:

This reverts commit 4e62d0005a
This reverts commit 0f0c370520
This reverts commit ad0efd04ee

Signed-off-by: chao an <anchao@lixiang.com>
 2024-06-06 22:00:25 +08:00
chao an 0f0c370520 fs/inode: replace some global variables to macro 
replace to macro will help to extend the scheduling implementation

Signed-off-by: chao an <anchao@lixiang.com>
 2024-03-21 18:53:14 +08:00
chao an d29748258b fs/inode: add pre-allocated task files to avoid allocator access 
Pre-allocated files to avoid allocator access during thread creation
phase, For functional safety requirements, increase
CONFIG_NFILE_DESCRIPTORS_PER_BLOCK could also avoid allocator access
caused by the file descriptor exceeding the limit.

For Task Termination, the time consumption will be reduced ~3us (Tricore TC397 300MHZ):
10.65(us) -> 7.35(us)

NOTE:
This commit will not waste of extra heap, just pre-allocates the list of files for task_group.

Signed-off-by: chao an <anchao@lixiang.com>
 2024-03-07 10:58:55 +08:00
hujun5 236ec9844f fs: dup3 should pass the fdcheck & fdsan 
Signed-off-by: hujun5 <hujun5@xiaomi.com>
Signed-off-by: ligd <liguiding1@xiaomi.com>
 2024-03-07 09:08:48 +08:00
ligd 9f51c47c10 fs: remove un-useful memcpy() in nx_close_from_tcb() 
Signed-off-by: ligd <liguiding1@xiaomi.com>
 2024-03-07 09:08:48 +08:00
ligd e1cd082c29 fs: enhance dup3() mulit-threads saftey 
Signed-off-by: ligd <liguiding1@xiaomi.com>
 2024-03-07 09:08:48 +08:00
ligd 60b25556d4 fs: enhance file_allocate_from_tcb() mulit-threads saftey 
Signed-off-by: ligd <liguiding1@xiaomi.com>
 2024-03-07 09:08:48 +08:00
hujun5 577eb47966 fdcheck: Enable fdcheck to automatically detect ownership of fd 
Signed-off-by: hujun5 <hujun5@xiaomi.com>
 2024-03-07 09:08:48 +08:00
chao an 5424ace1cf compiler/tasking: fix compiler warning on tasking 
ctc W549: ["serial/serial.c" 877/37] condition is always true
ctc W549: ["inode/fs_inodesearch.c" 72/8] condition is always true
ctc W545: ["obstack/lib_obstack_malloc.c" 69/1] missing 'return'
ctc W545: ["obstack/lib_obstack_malloc.c" 82/1] missing 'return'

Signed-off-by: chao an <anchao@lixiang.com>
 2024-01-31 05:02:56 -08:00
Zhe Weng bffe858e47 fs/proc: Fix groupfd to get fd by group instead of current tcb 
/proc/<pid>/group/fd should read the fds of <pid>, not current tcb.

Signed-off-by: Zhe Weng <wengzhe@xiaomi.com>
 2023-12-04 21:37:28 -08:00
chao an 59cf308eff sched/taskspawn: fix spawn fail if enable FDCHECK 
protect file descriptor before compare

Signed-off-by: chao an <anchao@xiaomi.com>
 2023-11-22 16:05:36 +01:00
chao an 42427e9e29 sched/taskfiles: skip unnecessary file open/close operations to improve performance 
The task files should consult the "spawn action" and "O_CLOEXEC flags"
to determine further whether the file should be duplicated.

This PR will further optimize file list duplicating to avoid the performance
regression caused by additional file operations.

Signed-off-by: chao an <anchao@xiaomi.com>
 2023-11-16 07:30:36 -08:00
chao an d63034994e fs/inode: check file list before memcpy 
The file list is NULL if task group initialized, check the validity
of the file list before memcpy.

Signed-off-by: chao an <anchao@xiaomi.com>
 2023-11-14 19:11:32 -03:00
chao an 3b2c585ab7 fs/inode: add common function to get file count from list 
common function to get file count from file list

Signed-off-by: chao an <anchao@xiaomi.com>
 2023-11-12 17:01:13 -08:00
chao an 0a567bbae4 fs/inode: improve the performance of get file pointer 
Remove file locks and enter critical sections to protect file lists

Signed-off-by: chao an <anchao@xiaomi.com>
 2023-11-12 17:01:13 -08:00
raiden00pl 607792d452 fs_files.c: make sure that fs_getfilep is not interrupted when holding mutex 
this fixes the issue https://github.com/apache/nuttx/issues/6012
 2023-11-07 01:07:57 +08:00
Xiang Xiao 949d01be51 fs/inode: Change inode_unlink to static function 
since it's only be called by inode_remove now

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2023-10-30 10:57:14 +02:00
dongjiuzhu1 18819b6b24 sched/task: close file descriptor with O_CLOEXEC before active task or exec 
VELAPLATFO-18473

refs:
https://man7.org/linux/man-pages/man2/fcntl.2.html
If the FD_CLOEXEC bit is set, the file descriptor will automatically
be closed during a successful execve(2).
(If the execve(2) fails, the file descriptor is left open.)

modify:
1. Ensure that the child task copies all fds of the parent task,
   including those with O_CLOEXE.
2. Make sure spawn_file_action is executed under fd with O_CLOEXEC,
   otherwise it will fail.
3. When a new task is activated or exec is called, close all fds
   with O_CLOEXEC flags.

Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
 2023-10-27 21:15:07 +08:00
dongjiuzhu1 73dc8f84cc fs/dup3: impletement dup3/nx_dup3_from_tcb function 
refs: https://man7.org/linux/man-pages/man2/dup.2.html

Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
 2023-10-27 21:15:07 +08:00
Xiang Xiao d84aba8a42 fs: Change inode_checkflags to static function 
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2023-10-22 21:23:08 +03:00
chao an 664927c86e mm/alloc: remove all unnecessary cast for alloc 
Fix the minor style issue and remove unnecessary cast

Signed-off-by: chao an <anchao@xiaomi.com>
 2023-08-30 14:34:20 +08:00
chao an 7aa45305b7 fs/inode: remove all unnecessary check for filep/inode 
Since VFS layer already contains sanity checks, so remove unnecessary lower half checks

Signed-off-by: chao an <anchao@xiaomi.com>
 2023-08-29 09:47:11 +08:00
Petro Karashchenko 4bebf64d6b fs/inode: add missing FAR 
Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
 2023-08-08 11:58:29 -03:00
Petro Karashchenko b3d620152e Revert "Don't call lib_free in the kernel code" 
This reverts commit 7884c18620.
 2023-08-08 11:58:29 -03:00
Xiang Xiao 7884c18620 Don't call lib_free in the kernel code 
since kernel just allocate memory from kmm_malloc

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
 2023-08-06 06:51:24 -03:00
dongjiuzhu1 f8ce0cd4ca fs/pseudofile: config pseudofile feature 
Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
 2023-07-31 22:22:58 -07:00