OrgApache/incubator-nuttx
OrgApache
/
incubator-nuttx
mirror of https://github.com/apache/incubator-nuttx.git
1
0
Fork 0
Code Issues Releases Wiki Activity

sched/group/group_setuid.c and group_setguid.c: Verify that the UID/GID is within range.

This commit is contained in:
Gregory Nutt 2019-08-10 10:42:53 -06:00
parent 5585cc421c
commit e6da85deb3
3 changed files with 52 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libs/libc/unistd/lib_setgid.c
View File

@ -39,6 +39,7 @@
#include <nuttx/config.h>
#include <sys/types.h>
#include <unistd.h>
#include <errno.h>
@ -55,7 +56,7 @@
* privileges.
*
* Input Parameters:
* uid - User identity to set the various process' user ID attributes to.
* gid - Identity to set the various process' group ID attributes to.
*
* Returned Value:
* Zero if successful and -1 in case of failure, in which case errno is set

29
sched/group/group_setgid.c
View File

@ -57,18 +57,39 @@
* privileges.
*
* Input Parameters:
* uid - User identity to set the various process' user ID attributes to.
* gid - Identity to set the various process' group ID attributes to.
*
* Returned Value:
* Zero if successful and -1 in case of failure, in which case errno is set
* appropriately.
* to one of he following values:
*
* EINVAL - The value of the uid argument is invalid and not supported by
* the implementation.
* EPERM - The process does not have appropriate privileges and uid does
* not match the real group ID or the saved set-group-ID.
*
****************************************************************************/
int setgid(gid_t gid)
{
FAR struct tcb_s *rtcb = this_task();
FAR struct task_group_s *rgroup = rtcb->group;
FAR struct tcb_s *rtcb;
FAR struct task_group_s *rgroup;
/* Verify that the GID is in the valid range of 0 through INT16_MAX.
* OpenGroup.org does not specify a GID_MAX or GID_MIN. Instead we use a
* priori knowledge that gid_t is type int16_t.
*/
if ((uint16_t)gid > INT16_MAX)
{
set_errno(EINVAL);
return ERROR;
}
/* Get the currently executing thread's task group. */
rtcb = this_task();
rgroup = rtcb->group;
/* Set the task group's group identity. */

28
sched/group/group_setuid.c
View File

@ -39,6 +39,7 @@
#include <nuttx/config.h>
#include <sys/types.h>
#include <unistd.h>
#include <errno.h>
@ -61,14 +62,35 @@
*
* Returned Value:
* Zero if successful and -1 in case of failure, in which case errno is set
* appropriately.
* to one of he following values:
*
* EINVAL - The value of the uid argument is invalid and not supported by
* the implementation.
* EPERM - The process does not have appropriate privileges and uid does
* not match the real user ID or the saved set-user-ID.
*
****************************************************************************/
int setuid(uid_t uid)
{
FAR struct tcb_s *rtcb = this_task();
FAR struct task_group_s *rgroup = rtcb->group;
FAR struct tcb_s *rtcb;
FAR struct task_group_s *rgroup;
/* Verify that the UID is in the valid range of 0 through INT16_MAX.
* OpenGroup.org does not specify a UID_MAX or UID_MIN. Instead we use a
* priori knowledge that uid_t is type int16_t.
*/
if ((uint16_t)uid > INT16_MAX)
{
set_errno(EINVAL);
return ERROR;
}
/* Get the currently executing thread's task group. */
rtcb = this_task();
rgroup = rtcb->group;
/* Set the task group's group identity. */