OrgApache/incubator-nuttx
OrgApache
/
incubator-nuttx
mirror of https://github.com/apache/incubator-nuttx.git
1
0
Fork 0
Code Issues Releases Wiki Activity

mpfs_usb.c: Remove PMPCFG configuration from the driver 

This is not the right place to modify DMA memory protection values.

Why not? These are designed to protect other AMP mode instances. Opening
the entire SoC's memory for the USB DMA kind of defeats this purpose.

Also, the driver cannot know how to configure these registers correctly,
only opening up the whole SoC "works".
This commit is contained in:
Ville Juven 2024-01-11 12:18:24 +02:00 committed by Xiang Xiao
parent c04f1e7789
commit a0901ec142
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
arch/risc-v/src/mpfs/mpfs_usb.c
View File

@ -3613,7 +3613,7 @@ static void mpfs_usb_iomux(void)
#ifdef CONFIG_USBDEV_DMA
/* DMA operations need to open the USB PMP registers for proper
* operation. If not configured, apply default settings.
* operation.
*/
uint64_t pmpcfg_usb_x;
@ -3622,28 +3622,24 @@ static void mpfs_usb_iomux(void)
if ((pmpcfg_usb_x & 0x1ffffff000000000llu) != 0x1f00000000000000llu)
{
uerr("Please check the MPFS_PMPCFG_USB_0 register.\n");
putreg64(0x1f00000fffffffffllu, MPFS_PMPCFG_USB_0);
}
pmpcfg_usb_x = getreg64(MPFS_PMPCFG_USB_1);
if ((pmpcfg_usb_x & 0x1ffffff000000000llu) != 0x1f00000000000000llu)
{
uerr("Please check the MPFS_PMPCFG_USB_1 register.\n");
putreg64(0x1f00000fffffffffllu, MPFS_PMPCFG_USB_1);
}
pmpcfg_usb_x = getreg64(MPFS_PMPCFG_USB_2);
if ((pmpcfg_usb_x & 0x1ffffff000000000llu) != 0x1f00000000000000llu)
{
uerr("Please check the MPFS_PMPCFG_USB_2 register.\n");
putreg64(0x1f00000fffffffffllu, MPFS_PMPCFG_USB_2);
}
pmpcfg_usb_x = getreg64(MPFS_PMPCFG_USB_3);
if ((pmpcfg_usb_x & 0x1ffffff000000000llu) != 0x1f00000000000000llu)
{
uerr("Please check the MPFS_PMPCFG_USB_3 register.\n");
putreg64(0x1f00000fffffffffllu, MPFS_PMPCFG_USB_3);
}
#endif
}