From 6eac8bf28dc20c1ec88f7d885272cd05395195ef Mon Sep 17 00:00:00 2001 From: Gregory Nutt Date: Tue, 31 May 2016 17:31:15 -0600 Subject: [PATCH] Update some comments --- arch/arm/src/stm32/stm32f40xxx_rtcc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm/src/stm32/stm32f40xxx_rtcc.c b/arch/arm/src/stm32/stm32f40xxx_rtcc.c index 6623efa711..483bf4df28 100644 --- a/arch/arm/src/stm32/stm32f40xxx_rtcc.c +++ b/arch/arm/src/stm32/stm32f40xxx_rtcc.c @@ -108,7 +108,11 @@ # define RCC_XXX_RTCSEL_LSI RCC_BDCR_RTCSEL_LSI # define RCC_XXX_RTCSEL_HSE RCC_BDCR_RTCSEL_HSE -/* BCD conversions */ +/* BCD conversions. + * FIXME: rtc_reg_alrmr_bin2bcd() sets only the hour, minute, seconds + * field. It does not set the month or year fields. This breaks the + * alarm for times > 24 hours. THIS NEEDS TO BE FIXED!!! + */ #define rtc_reg_tr_bin2bcd(tp) \ ((rtc_bin2bcd((tp)->tm_sec) << RTC_TR_SU_SHIFT) | \