OrgApache/incubator-nuttx
OrgApache
/
incubator-nuttx
mirror of https://github.com/apache/incubator-nuttx.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Remove unnecessary enter/leave_critical_section() in setlogmask() because it is MT-unsafe.

This commit is contained in:
Nakamura, Yuuichi 2020-05-11 09:30:49 +09:00 committed by patacongo
parent d666aa623f
commit 46baccb521
1 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
libs/libc/syslog/lib_setlogmask.c
View File

@ -1,7 +1,8 @@
/****************************************************************************
* lib/syslog/lib_setlogmask.c
*
* Copyright (C) 2007-2009, 2011-2012, 2016 Gregory Nutt. All rights reserved.
* Copyright (C) 2007-2009, 2011-2012, 2016 Gregory Nutt. All rights
* reserved.
* Author: Gregory Nutt <gnutt@nuttx.org>
*
* Redistribution and use in source and binary forms, with or without
@ -42,8 +43,6 @@
#include <stdint.h>
#include <syslog.h>
#include <nuttx/irq.h>
#include "syslog/syslog.h"
/****************************************************************************
@ -91,17 +90,9 @@ uint8_t g_syslog_mask = LOG_ALL;
int setlogmask(int mask)
{
uint8_t oldmask;
irqstate_t flags;
/* These operations must be exclusive with respect to other threads as well
* as interrupts.
*/
flags = enter_critical_section();
oldmask = g_syslog_mask;
g_syslog_mask = (uint8_t)mask;
leave_critical_section(flags);
return oldmask;
}