OrgApache/incubator-nuttx
OrgApache
/
incubator-nuttx
mirror of https://github.com/apache/incubator-nuttx.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Remove check for outstanding un-ACKed data in TX poll 

git-svn-id: svn://svn.code.sf.net/p/nuttx/code/trunk@2038 42af7a65-404d-4744-a932-0658087f49c3
This commit is contained in:
patacongo 2009-09-11 20:32:02 +00:00
parent 80113f7d41
commit 44f3418b18
3 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ChangeLog
View File

@ -863,3 +863,6 @@
* net/net_close.c. Fixed another important TCP/IP race condition bug: If
the host closes the TCP connection just before the target calls close(), then
the close operation may hang indefinitely!
* net/net_tcppoll.c. Removed an unnecessary check for outstanding, un-ACKed
data. The NuttX socket layer keeps track of ACKs and doesn't need this check;
removing the check should improve write throughput

3
Documentation/NuttX.html
View File

@ -1524,6 +1524,9 @@ nuttx-0.4.11 2009-xx-xx Gregory Nutt <spudmonkey@racsa.co.cr>
* net/net_close.c. Fixed another important TCP/IP race condition bug: If
the host closes the TCP connection just before the target calls close(), then
the close operation may hang indefinitely!
* net/net_tcppoll.c. Removed an unnecessary check for outstanding, un-ACKed
data. The NuttX socket layer keeps track of ACKs and doesn't need this check;
removing the check should improve write throughput
pascal-0.1.3 2009-xx-xx Gregory Nutt <spudmonkey@racsa.co.cr>

7
net/uip/uip_tcppoll.c
View File

@ -96,12 +96,9 @@ void uip_tcppoll(struct uip_driver_s *dev, struct uip_conn *conn)
{
uint8 result;
/* Verify that the connection is established and if the connection has
* no outstanding (unacknowledged) sent data.
*/
/* Verify that the connection is established */
if ((conn->tcpstateflags & UIP_TS_MASK) == UIP_ESTABLISHED &&
!uip_outstanding(conn))
if ((conn->tcpstateflags & UIP_TS_MASK) == UIP_ESTABLISHED)
{
/* Set up for the callback */