From 2b7742fc08b235d4b71e3c64a3b61f9ad9680855 Mon Sep 17 00:00:00 2001 From: chao an Date: Thu, 7 Mar 2024 16:34:41 +0800 Subject: [PATCH] binfmt/task/member: remove invaild membership reverse As long as the process id reversed between parent and child, the process member ship will automatically reversed. Fix Regression by PR #11848: | commit ec08031e4bf01f0abc9e590484382c166d90915e | Author: chao an | Date: Wed Mar 6 10:13:47 2024 +0800 | | sched/group: change type of task group member to single queue | | Change the type of task group member to single list chain to | avoid accessing the memory allocator to improve the performance | | Signed-off-by: chao an Signed-off-by: chao an --- binfmt/binfmt_execmodule.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/binfmt/binfmt_execmodule.c b/binfmt/binfmt_execmodule.c index 0f5fffc0a6..e1813b7034 100644 --- a/binfmt/binfmt_execmodule.c +++ b/binfmt/binfmt_execmodule.c @@ -120,9 +120,6 @@ static void exec_swap(FAR struct tcb_s *ptcb, FAR struct tcb_s *chtcb) int chndx; pid_t pid; irqstate_t flags; -#ifdef HAVE_GROUP_MEMBERS - sq_queue_t tg_members; -#endif #ifdef CONFIG_SCHED_HAVE_PARENT # ifdef CONFIG_SCHED_CHILD_STATUS FAR struct child_status_s *tg_children; @@ -163,12 +160,6 @@ static void exec_swap(FAR struct tcb_s *ptcb, FAR struct tcb_s *chtcb) chtcb->group->tg_ppid = ptcb->group->tg_ppid; ptcb->group->tg_ppid = pid; -#ifdef HAVE_GROUP_MEMBERS - tg_members = chtcb->group->tg_members; - chtcb->group->tg_members = ptcb->group->tg_members; - ptcb->group->tg_members = tg_members; -#endif - #ifdef CONFIG_SCHED_HAVE_PARENT # ifdef CONFIG_SCHED_CHILD_STATUS tg_children = chtcb->group->tg_children;