From 23b8b397999136c61b3c834956ad1da55fb0e072 Mon Sep 17 00:00:00 2001 From: Gregory Nutt Date: Wed, 4 Mar 2020 17:09:23 -0600 Subject: [PATCH] sched/group/group_setuptaskfiles.c: Fix bad file inclusion. Also remove the horrible violation of the architectural rules by adding an include path into net in sched/group/Make.defs. Folks, if you are going to participate in this project, you MUST respect the odule architecture and never, never, never do these things. commit d07afc934e272cbbd63e355d9e12db333b2e2978, "fcntl: add O_CLOEXEC/FD_CLOEXEC support" introduce a compilation error .. a bad file inclusion. That commit added an unnecessary inclusion of "socket/socket.h" which is NOT available in the sched sub-directory. It is only available under the net/ sub-directory. There is no include path for such and inclusion and there must NEVER be such a include path. Module design forbids including header files between diffent "silos" in the design. Nothing under net/ can ever be available to logic under sched/. --- sched/group/Make.defs | 2 -- sched/group/group_setuptaskfiles.c | 1 - 2 files changed, 3 deletions(-) diff --git a/sched/group/Make.defs b/sched/group/Make.defs index d59fce3eb2..a8039475e7 100644 --- a/sched/group/Make.defs +++ b/sched/group/Make.defs @@ -76,5 +76,3 @@ endif DEPPATH += --dep-path group VPATH += :group - -CFLAGS += ${shell $(INCDIR) $(INCDIROPT) "$(CC)" $(TOPDIR)$(DELIM)net} diff --git a/sched/group/group_setuptaskfiles.c b/sched/group/group_setuptaskfiles.c index 21532e5f81..b481e46743 100644 --- a/sched/group/group_setuptaskfiles.c +++ b/sched/group/group_setuptaskfiles.c @@ -47,7 +47,6 @@ #include #include "sched/sched.h" -#include "socket/socket.h" #include "group/group.h" /****************************************************************************