OrgApache/incubator-nuttx
OrgApache
/
incubator-nuttx
mirror of https://github.com/apache/incubator-nuttx.git
1
0
Fork 0
Code Issues Releases Wiki Activity

tools/nxstyle.c: Correct false alarm detection (#106) 

Commit cf5d17f795 added logic to detect #define pre-processor definitions outside of the "Pre-processor Definitions" file section.  That commit was verified against numerous .c source files.  But not against any .h header files.

When run against a header file, that change causes a false alarm warning like:

  file:line:pos: warning: #define outside of 'Pre-processor Definitions' section

That is caused the idempotence, guard definition that must appear in the header file BEFORE the first file section.

This commit adds logic to nxstyle to ignore pre-processor definitions in header files that occur before the first file section is encountered.
This commit is contained in:
patacongo 2020-01-15 13:25:18 -06:00 committed by Ouss4
parent d1dd2841c5
commit 0e77e3373e
1 changed files with 16 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
tools/nxstyle.c
View File

@ -844,15 +844,24 @@ int main(int argc, char **argv, char **envp)
{
if (g_section != PRE_PROCESSOR_DEFINITIONS)
{
/* Only a warning because there is some usage of
* define outside the Pre-processor Definitions
* section which is justifiable. Should be
* manually checked.
/* A complication is the header files always have
* the idempotence guard definitions before the
* "Pre-processor Definitions section".
*/
WARN("#define outside of 'Pre-processor "
"Definitions' section",
lineno, ii);
if (g_section == NO_SECTION &&
g_file_type != C_HEADER)
{
/* Only a warning because there is some usage
* of define outside the Pre-processor
* Definitions section which is justifiable.
* Should be manually checked.
*/
WARN("#define outside of 'Pre-processor "
"Definitions' section",
lineno, ii);
}
}
}