OrgApache/incubator-nuttx
OrgApache
/
incubator-nuttx
mirror of https://github.com/apache/incubator-nuttx.git
1
0
Fork 0
Code Issues Releases Wiki Activity

maXTouch: Be consistent. Failure return values are not just non-zero, but negative

This commit is contained in:
Gregory Nutt 2014-07-06 09:08:38 -06:00
parent 4afc23d16d
commit 09d0e2bdd2
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/input/mxt.c
View File

@ -1382,7 +1382,7 @@ static int mxt_getobjtab(FAR struct mxt_dev_s *priv)
tabsize = priv->info.nobjects * sizeof(struct mxt_object_s);
ret = mxt_getreg(priv, MXT_OBJECT_START, (FAR uint8_t *)priv->objtab,
tabsize);
if (ret)
if (ret < 0)
{
return ret;
}
@ -1507,7 +1507,7 @@ static int mxt_hwinitialize(FAR struct mxt_dev_s *priv)
/* Get object table information */
ret = mxt_getobjtab(priv);
if (ret)
if (ret < 0)
{
goto errout_with_objtab;
}
@ -1520,7 +1520,7 @@ static int mxt_hwinitialize(FAR struct mxt_dev_s *priv)
/* Update matrix size in the info structure */
ret = mxt_getreg(priv, MXT_MATRIX_X_SIZE, (FAR uint8_t *)&regval, 1);
if (ret)
if (ret < 0)
{
goto errout_with_objtab;
}
@ -1528,7 +1528,7 @@ static int mxt_hwinitialize(FAR struct mxt_dev_s *priv)
info->xsize = regval;
ret = mxt_getreg(priv, MXT_MATRIX_Y_SIZE, (FAR uint8_t *)&regval, 1);
if (ret)
if (ret < 0)
{
goto errout_with_objtab;
}
@ -1577,7 +1577,7 @@ static int mxt_hwinitialize(FAR struct mxt_dev_s *priv)
/* Force the CHG pin to the high state */
ret = mxt_chghigh(priv);
if (ret)
if (ret < 0)
{
goto errout_with_sample;
}