Commit Graph

417 Commits

Author SHA1 Message Date
Liam Girdwood c9a4c87d7a
Merge pull request #114 from plbossart/fix/ipc-alignment
topology: renumber SSP tokens - ABI CHANGE
2018-10-24 14:03:04 +01:00
Liam Girdwood b315f9bfd4
Merge pull request #113 from singalsu/fix_src_host_testbench_paths
Test: Audio: Fix paths in SRC host version testbench
2018-10-24 11:51:47 +01:00
Liam Girdwood 5d7c535a21
Merge pull request #112 from singalsu/add_dmic_2ch_4ch_topologies
Topology: Add 2ch and 4ch raw DMIC capture topologies for APL
2018-10-24 10:18:42 +01:00
Pierre-Louis Bossart 8d0f1783a6 topology: renumber SSP tokens - ABI CHANGE
Initial _ACTIVE fields are replaced by a single clock control
This change can lead to regressions, it needs to be aligned with the same
change at the kernel level.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
2018-10-23 12:28:47 -05:00
Seppo Ingalsuo 092db5e225 Test: Audio: Fix paths in SRC host version testbench
The directories were restructured lately and this patch fixes the
changed paths issue.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
2018-10-23 14:52:08 +03:00
Seppo Ingalsuo 8d4b10c539 Topology: Add 2ch and 4ch raw DMIC capture topologies for APL
This patch adds two minimal capture topologies to enable doing tests
those require raw audio capture with unmodified S32_LE samples, e.g.
channels order preserve test where the mic # origin can be checked
from side information in LSB bits.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
2018-10-23 11:27:25 +03:00
Liam Girdwood a1dfcb7f4b
Merge pull request #110 from xiulipan/pr/daidir
Add direction for dai widget in topology
2018-10-18 16:58:20 +01:00
Liam Girdwood 64c0e8d6ec
Merge pull request #109 from xiulipan/pr/pplfmt
topology: duplicate dai formart for pcm add
2018-10-18 16:57:18 +01:00
Pan Xiuli 25dcef9219 topolgy: m4: add direction for widget dai
Add direction for widget dai, 0 for playback and 1 for capture.

Signed-off-by: Rander Wang <rander.wang@linux.intel.com>
Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
2018-10-18 18:59:24 +08:00
Pan Xiuli 489832137c topology: m4: add SOF_TKN_DAI_DIRECTION for DAI
Signed-off-by: Rander Wang <rander.wang@linux.intel.com>
Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
2018-10-18 18:59:18 +08:00
Pan Xiuli b6016cd5e5 topology: duplicate dai formart for pcm add
In PIPELINE_PCM_ADD, DAI_FORMAT is not set but are used later.
Need to set this value to avoid protenial issues.

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
2018-10-18 18:43:37 +08:00
Liam Girdwood b3764048e9
Merge pull request #90 from singalsu/fix_nocodec_dmic_pcm
Topology: DMIC: Reduce PCM capabilities to DMIC configuration
2018-10-18 11:20:44 +01:00
Seppo Ingalsuo 53f90d9c6a Topology: DMIC: Reduce PCM capabilities to DMIC configuration
This patch impacts topologies sof-apl-nocodec, sof-apl-da7219, and
sof-glk-da7219 those use the pipe-passthrough-capture macro for DMIC.

The PCM saple rate is limited to 48 kHz (was 8 - 192 kHz). The capture
channels count can be only PIPELINE_CHANNELS (was 1 - PIPELINE_CHANNELS).
This prevents corrupted audio capture that happens when DMIC topology
parameters and capture parameters differ. It happens because DMIC FIFOs
drop samples or add unwanted samples when the configuration does not match.

In sof-apl-nocodec topology the PIPELINE_CHANNELS is set to 2 that
matches the configuration.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
2018-10-18 12:42:38 +03:00
Liam Girdwood 5b51dc0d4b
Merge pull request #108 from singalsu/eqctl_check_calloc_and_return_zero
eqctl: Add check for calloc() success and return 0 in exit
2018-10-15 20:38:52 +01:00
Seppo Ingalsuo 7a8ed190e8 eqctl: Add check for calloc() success and return 0 in exit
This patch adds the missed details into the code.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
2018-10-15 19:20:26 +03:00
Liam Girdwood b37b8ef00c
Merge pull request #104 from bkokoszx/readme_update
readme: upgrade readme with logger instruction
2018-10-15 16:31:59 +01:00
Liam Girdwood 0e1680532d
Merge pull request #105 from bkokoszx/sof-logger
rmbox: change binary names of logger and rmbox
2018-10-15 16:31:37 +01:00
Bartosz Kokoszko c8f671b746 rmbox: change bins name to sof-logger sof-rmbox
Change binary names:
from logger to sof-logger and
from rmbox to sof-rmbox

Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
2018-10-15 15:18:34 +02:00
Bartosz Kokoszko e6885d04a7 readme: upgrade readme with sof-logger instruction
Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
2018-10-15 15:13:07 +02:00
Liam Girdwood 9033d35058
Merge pull request #100 from bkokoszx/logger_kw
rmbox: fix rmbox KW issues
2018-10-15 12:51:45 +01:00
Liam Girdwood 9df6d36a52
Merge pull request #103 from bkokoszx/logger_usage
rmbox: usage function refinement
2018-10-15 12:48:45 +01:00
Bartosz Kokoszko 7ad6c23121 rmbox: fix rmbox KW issues
Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
2018-10-15 13:41:17 +02:00
Liam Girdwood 06a42dd68f
Merge pull request #107 from singalsu/eq_iir_fix_assign_integer_type
EQ: Fix an integer type bug in IIR coefficients blob packer
2018-10-15 12:40:14 +01:00
Liam Girdwood b76776ba8c
Merge pull request #106 from singalsu/eq_path_change_updates
EQ: Update new path into objective quality test functions
2018-10-15 12:39:55 +01:00
Liam Girdwood 282a318c2e
Merge pull request #80 from xiulipan/pr/up2hdmi
topology: enable hdmi support on UP2 board
2018-10-15 12:37:55 +01:00
Bartosz Kokoszko c9731f1678 rmbox: usage function refinement
Refines the output content when displaying the logger usage.

Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
2018-10-15 11:08:06 +02:00
Seppo Ingalsuo 0913d7c83a EQ: Fix an integer type bug in IIR coefficients blob packer
This patch adds explicit conversion to signed int32 type for response to
channels indices in assign_response and filter coefficients. The bug was
visible if trying to activate in IIR blob the per channel filter bypass
by having a negative value (-1) in any of channel assigns. Octave assumed
the type to be unsigned and produced wrong configuration bytes.

The filter coefficients are already integer type from previous
quantization code in the conversion process. However it does not hurt to
have extra safety to avoid similar issue as assign.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
2018-10-15 10:54:48 +03:00
Seppo Ingalsuo 9250bfe034 EQ: Update new path into objective quality test functions
This patch fixes the path issue from previous directory structure
maintenance.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
2018-10-15 10:44:42 +03:00
Pan Xiuli 97ae708c5e topology: enable hdmi support on UP2 board
Add HDMI support to sof-apl-pcm512x

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
2018-10-15 08:16:24 +08:00
Liam Girdwood c0a881a3b7
Merge pull request #101 from juimonen/test_pr
tests: add qa tests and rearrange other tests under one directory
2018-10-14 22:41:17 +01:00
Liam Girdwood 6efe3d4470
Merge pull request #95 from singalsu/tplg_add_iir_dmic_pipe
Topology: Add DMIC capture pipeline with gain and high-pass filter
2018-10-14 22:37:31 +01:00
Jaska Uimonen 0808765bf4 tests: add qa tests and rearrange other tests under one directory
Previously we used to have tests scattered around, so let's put
them under one directory to make things more clear.

Now under top level test directory we have directories:

audio - objective audio quality tests
used to be under test/

qa - qa tests run by the CI
new test component in soft repo

topology - topology test file generation
used to be under topology/tests

Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
2018-10-12 08:12:49 +03:00
Seppo Ingalsuo 27281d75e7 Topology: Add DMIC capture pipeline with gain and high-pass filter
This patch adds topology sof-apl-eq-dmic to help testing acoustical
audio capture via DMIC or work as example for other machine drivers. The
capture format is set as four channels, S32_LE, 48 kHz. The IIR EQ is
a 2nd order Butterworth high-pass with cut-off frequency at 50 Hz to
suppress non-audible lowest frequencies. The EQ provides additional
+20 dB gain to avoid the recording to sound too silent.

The IIR EQ or additional FIR EQ instance can when needed provide other
form factor specific equalization.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
2018-10-11 17:12:27 +03:00
Liam Girdwood 7f47792cbd
Merge pull request #99 from singalsu/eq_add_response_measure
EQ: Add tool for acoustical frequency response measurement
2018-10-11 12:14:17 +01:00
Liam Girdwood 878d08831c
Merge pull request #98 from akloniex/trace-improvements
logger: Add support for 4 parameters passed to log message.
2018-10-10 16:40:34 +01:00
Liam Girdwood 3e848fe2e5
Merge pull request #97 from akloniex/fix-formatting
logger: Fix formatting of line number value.
2018-10-10 16:38:54 +01:00
Liam Girdwood 3c59e53943
Merge pull request #96 from akloniex/read-stdin
logger: Implement possibility to read log data from stdin
2018-10-10 16:29:48 +01:00
Liam Girdwood b6046db271
Merge pull request #93 from RanderWang/whl_tplg
WHL: add a bespoke hda topology for WHL
2018-10-10 16:17:10 +01:00
Seppo Ingalsuo 1cbba6c5e8 EQ: Add tool for acoustical frequency response measurement
This patch adds into SOFT/tune/eq a script mls_freq_resp.m that can
be used as low budget or quick developer tool to measure device frequency
response. The configuration files mls_play_config.txt and
mls_rec_config.txt configure the audio devices for local or remote
ssh aplay/arecord execution.

The MLS measurement with a short time window, e.g. less than 10 ms can
partially achieve the same as anechoic measurement. However this
is not intended to replace usage any professional audio measurement. If
using this use with care!

Note also that as such this script measures the response of a
speaker - microphone system. One response need to be known and
under calibration to get reliable results for other. Even ADC and DAC
responses may impact.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
2018-10-10 16:43:38 +03:00
ArturX Kloniecki 3bf2641ef5 logger: Add support for 4 parameters passed to log message.
Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
2018-10-10 11:44:12 +02:00
ArturX Kloniecki 932f09f0c2 logger: Fix formatting of line number value.
Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
2018-10-10 09:17:54 +02:00
ArturX Kloniecki 5e4995f995 logger: Implement possibility to read log data from stdin
Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
2018-10-09 14:37:24 +02:00
Rander Wang c569a95905 WHL: add a bespoke hda topology for WHL
Only passthrough is required on WHL

Signed-off-by: Rander Wang <rander.wang@linux.intel.com>
2018-10-09 10:52:06 +08:00
Liam Girdwood e37aa3f422
Merge pull request #88 from akloniex/unify-logger
logger/rmbox: unify implementation of new logger tool with old rmbox
2018-10-08 20:40:37 +01:00
ArturX Kloniecki 86b8dafe41 logger/rmbox: unify implementation of new logger tool with old rmbox
Integrate both tools to provide common CLI.
Also provide better logging format for logger tool.

Signed-off-by: ArturX Kloniecki arturx.kloniecki@linux.intel.com
2018-10-08 19:38:35 +02:00
Liam Girdwood 2d7a933aa8
Merge pull request #91 from singalsu/fix_eq_m4_export
EQ tune: Update m4 format EQ filter coefficients syntax
2018-10-04 17:38:21 +01:00
Seppo Ingalsuo 7372f1ec7e EQ tune: Update m4 format EQ filter coefficients syntax
This patch updates the export format to currently used format in
topology. It adds also possibility to pass text comment into line
above the bytes from EQ design script. The date is appended
automatically after comment.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
2018-10-04 18:17:17 +03:00
Liam Girdwood 8a56694668
Merge pull request #89 from cujomalainey/master
Use passed in number of channels for pipeline
2018-10-03 13:17:52 +01:00
Curtis Malainey 9050d82a7d Use passed in number of channels for pipeline
Pipelines should not expose more channels than what they are configured
to support.

Signed-off-by: Curtis Malainey <cujomalainey@google.com>
2018-10-02 13:54:04 -07:00
Liam Girdwood 54d191e82b
Merge pull request #87 from ranj063/eqctl
eqctl: do not process invalid input file name
2018-10-02 08:32:38 +01:00