Let's stop ignoring build and test failures. Start gradually with the
scripts involved in testbench, more files later.
Follow-up to to bug #2752 "host-testbench.sh ignores errors" and commit
ab421466af ("CI: Travis: enable host testbnech again") and
ab421466aff826~1
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Currently, "set -e" is being ignored for type command using redirections
and "A && true". "A && true" is a no-op and a peculiar case where
"set -e" ignores the exit code of A.
Exit code of the "type" command is used in an if statement which is
exactly what the function of "if" command is. Also, "set -e" ignores
exit codes of commands used in if statements.
Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
Use getopts to parse the arguments instead of manual parsing to leave no
room for errors, bugs, and inconsistent conventions introduced by custom
implementation.
Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
`PLATFORMS` variable was used as an array while it is actually a string
used incorrectly making it work accidentally.
Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
CMAKE_VERBOSE_MAKE was sometimes "hardcoding" the decision in CMake's
cache. Move that decision to the make invocation.
After running xtensa-build-all.sh [-v], it's now possible to choose
again whether "make -C build_apl_gcc/" should be VERBOSE or not without
starting from scratch and with the exact same configuration.
Before this commit it was possible for make to decide again after a
non-verbose xtensa-build-all.sh but not possible to decide again after a
verbose xtensa-build-all.sh... very confusing.
Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Disable verbose build by default in build script.
It would be too annoying if we do not need to debug
with make systems.
Use -v option to enable verbose log if need.
Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Running on 120MHz Low Power Ring Oscillator enables more
aggressive power saving. Therefore this should be a default
options for all Cannonlake configurations that may run
on a single dsp core and does not need more than 120 MCPS.
Signed-off-by: Marcin Maka <marcin.maka@linux.intel.com>
Since xcc is the default toolchain for xtensa architecture,
the defconfigs should be customized for xcc.
gcc versions are saved for CI builds.
Signed-off-by: Marcin Maka <marcin.maka@linux.intel.com>
Update xcc build config for all existing platforms.
xcc build with byt, cht and sue need special defconfig.
Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
On specific Intel platforms, we have to use a private key which is not
shared with the rest of the world.
Extend xtensa-build-all.sh with an option, and pass the key path
explicitly to cmake if needed.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Build faster by using all available cores by default
The xtensa script claims it used infinite build threads when j was not
specified but it was actually falling back to 1.
Signed-off-by: Curtis Malainey <cujomalainey@google.com>
Add an option to modify the defconfig during fw build using the
script. Without this, modifying the default config and building
the FW is a 2 step process.
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Add -u option to allow force building xtensa(up) ARCH on platforms which
usually building xtensa-smp by default.
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Use different build folder for gcc and xcc build.
Will auto selected if ROM build is not supported for the platform,
thus make -a -r can work.
Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Add a debug option to include build number, date and time into build.
This will be disabled b default so that all builds are reproducible.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
make[1]: Leaving directory '/home/lrg/source/reef/sof.git'
./scripts/xtensa-build-all.sh: line 123: [: ==: unary operator expected
Fix, set variable to "none" if xcc not found.
Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Check ENV XTENSA_TOOLS_ROOT to determain which compiler to use, and set
the PATH and other ENV needed for xt-xcc.
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Add a flag "-l" to make rimage install only in pdw/local.
Also add parse for args, then simplify platform build for loop since in
parse the args will be all legal
Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Use /bin/sh by default. The lists used in xtensa-build-all.sh are a
bash feature, use bash for that script.
Signed-off-by: Dylan Reid <dgreid@chromium.org>
rimage is not built by default, which can lead to disconnects and
awful bugs when the memory layout changes.
Add rimage build+install as default for xtensa scripts
The BKM should be to rely on executing
./scripts/xtensa-build-all.sh [byt|cht|apl|cnl]
instead of manual commands...
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
The ROOT is already assumed to be as $pwd/../xtensa-root/$ROOT,
set the PATH as well
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
This patch modifies the build-all script for xtensa platforms
to make it easier to choose platforms
Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>